Thread: Win32 Version numbering patch

I was hoping this would be in for beta 3, but alas - can someone
*please* commit the win32 version patch at:

http://candle.pha.pa.us/mhonarc/patches/msg00000.html

With the correction at

http://candle.pha.pa.us/mhonarc/patches/msg00001.html

Without it we cannot reliably install files like libpq.dll on Windows!!

Regards, Dave

"Dave Page" <dpage@vale-housing.co.uk> writes:
> I was hoping this would be in for beta 3, but alas - can someone
> *please* commit the win32 version patch at:
> http://candle.pha.pa.us/mhonarc/patches/msg00000.html

Personally I was holding off in hopes of seeing a cleaner solution.
A patch that requires every executable-building Makefile to have a
platform-specific wart isn't going to be very maintainable.  You
already missed pg_config, plus whichever of the contrib modules build
executables...

            regards, tom lane

Tom Lane wrote:
> "Dave Page" <dpage@vale-housing.co.uk> writes:
> > I was hoping this would be in for beta 3, but alas - can someone
> > *please* commit the win32 version patch at:
> > http://candle.pha.pa.us/mhonarc/patches/msg00000.html
>
> Personally I was holding off in hopes of seeing a cleaner solution.
> A patch that requires every executable-building Makefile to have a
> platform-specific wart isn't going to be very maintainable.  You
> already missed pg_config, plus whichever of the contrib modules build
> executables...

I have added Win32 version information for pg_config.  I assume anyone
adding a new client binary will copy an existing one so I am hopeful the
win32 version strings will be maintained.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073