Thread: compile warnings in HEAD
I get the following warnings compiling current sources: /Users/neilc/pgsql/src/bin/pg_dump/pg_backup_db.c: In function `_isIdentChar': /Users/neilc/pgsql/src/bin/pg_dump/pg_backup_db.c:874: warning: comparison is always true due to limited range of data type /Users/neilc/pgsql/src/bin/pg_dump/pg_backup_db.c: In function `_isDQChar': /Users/neilc/pgsql/src/bin/pg_dump/pg_backup_db.c:891: warning: comparison is always true due to limited range of data type Default CFLAGS. Machine specs: [neilc:/Users/neilc/build-pgsql]% gcc -v Reading specs from /usr/libexec/gcc/darwin/ppc/3.3/specs Thread model: posix gcc version 3.3 20030304 (Apple Computer, Inc. build 1495) [neilc:/Users/neilc/build-pgsql]% uname -a Darwin CPE000a95ab279e-CM000a735d27c0 7.5.0 Darwin Kernel Version 7.5.0: Thu Aug 5 19:26:16 PDT 2004; root:xnu/xnu-517.7.21.obj~3/RELEASE_PPC Power Macintosh powerpc (i.e. OSX 10.3.5) -Neil
At 12:11 PM 24/08/2004, Neil Conway wrote: >I get the following warnings compiling current sources: My fault; I'll fix it in the next patch to pg_dump etc. I compare a char to the range \200 through \377. It must always be >= \200...at least I assume that's the problem. ---------------------------------------------------------------- Philip Warner | __---_____ Albatross Consulting Pty. Ltd. |----/ - \ (A.B.N. 75 008 659 498) | /(@) ______---_ Tel: (+61) 0500 83 82 81 | _________ \ Fax: (+61) 03 5330 3172 | ___________ | Http://www.rhyme.com.au | / \| | --________-- PGP key available upon request, | / and from pgp.mit.edu:11371 |/
Has this been fixed? --------------------------------------------------------------------------- Neil Conway wrote: > I get the following warnings compiling current sources: > > /Users/neilc/pgsql/src/bin/pg_dump/pg_backup_db.c: In function > `_isIdentChar': > /Users/neilc/pgsql/src/bin/pg_dump/pg_backup_db.c:874: warning: > comparison is always true due to limited range of data type > /Users/neilc/pgsql/src/bin/pg_dump/pg_backup_db.c: In function `_isDQChar': > /Users/neilc/pgsql/src/bin/pg_dump/pg_backup_db.c:891: warning: > comparison is always true due to limited range of data type > > Default CFLAGS. Machine specs: > > [neilc:/Users/neilc/build-pgsql]% gcc -v > Reading specs from /usr/libexec/gcc/darwin/ppc/3.3/specs > Thread model: posix > gcc version 3.3 20030304 (Apple Computer, Inc. build 1495) > [neilc:/Users/neilc/build-pgsql]% uname -a > Darwin CPE000a95ab279e-CM000a735d27c0 7.5.0 Darwin Kernel Version 7.5.0: > Thu Aug 5 19:26:16 PDT 2004; root:xnu/xnu-517.7.21.obj~3/RELEASE_PPC > Power Macintosh powerpc > > (i.e. OSX 10.3.5) > > -Neil > > > ---------------------------(end of broadcast)--------------------------- > TIP 4: Don't 'kill -9' the postmaster > -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001+ If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania19073
At 12:57 AM 27/08/2004, Bruce Momjian wrote:
>Has this been fixed?
In my local files, yes. I've been waiting on the 'set magic_tablespace'
code, but patch to fix the warnings only is attached.
----------------------------------------------------------------
Philip Warner | __---_____
Albatross Consulting Pty. Ltd. |----/ - \
(A.B.N. 75 008 659 498) | /(@) ______---_
Tel: (+61) 0500 83 82 81 | _________ \
Fax: (+61) 03 5330 3172 | ___________ |
Http://www.rhyme.com.au | / \|
| --________--
PGP key available upon request, | /
and from pgp.mit.edu:11371 |/
Attachment
Patch applied. Thanks. --------------------------------------------------------------------------- Philip Warner wrote: > At 12:57 AM 27/08/2004, Bruce Momjian wrote: > >Has this been fixed? > > In my local files, yes. I've been waiting on the 'set magic_tablespace' > code, but patch to fix the warnings only is attached. > > > > ---------------------------------------------------------------- > Philip Warner | __---_____ > Albatross Consulting Pty. Ltd. |----/ - \ > (A.B.N. 75 008 659 498) | /(@) ______---_ > Tel: (+61) 0500 83 82 81 | _________ \ > Fax: (+61) 03 5330 3172 | ___________ | > Http://www.rhyme.com.au | / \| > | --________-- > PGP key available upon request, | / > and from pgp.mit.edu:11371 |/ [ Attachment, skipping... ] > > ---------------------------(end of broadcast)--------------------------- > TIP 3: if posting/reading through Usenet, please send an appropriate > subscribe-nomail command to majordomo@postgresql.org so that your > message can get through to the mailing list cleanly -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001+ If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania19073