Thread: Re: [PATCHES] That dump-comments-on-composite-type-columns patch...

> Christopher Kings-Lynne <chriskl@familyhealth.com.au> writes:
> > OK, I can do this, but I don't think I'll have time for the first beta.
>
> No problem.

Another interesting think I noticed in pg_dump is dumping of LOBs.  It
seems to declare a cursor that fetches the blobs and then issues a fetch
1000 to get the first 1000 lobs.  It never seems to execute any further
fetches.  Am I right that if you have more than 1000 lobs in postgres,
pg_dump won't dump them?

Chris

Christopher Kings-Lynne <chriskl@familyhealth.com.au> writes:
> Another interesting think I noticed in pg_dump is dumping of LOBs.  It
> seems to declare a cursor that fetches the blobs and then issues a fetch
> 1000 to get the first 1000 lobs.  It never seems to execute any further
> fetches.

Huh?  That's inside a do-loop.
        regards, tom lane

>>Another interesting think I noticed in pg_dump is dumping of LOBs.  It
>>seems to declare a cursor that fetches the blobs and then issues a fetch
>>1000 to get the first 1000 lobs.  It never seems to execute any further
>>fetches.
> 
> 
> Huh?  That's inside a do-loop.

Errr, yeah.  Don't know what made me not notice that :/

Christopher Kings-Lynne wrote:
> > Christopher Kings-Lynne <chriskl@familyhealth.com.au> writes:
> > > OK, I can do this, but I don't think I'll have time for the first beta.
> >
> > No problem.
> 
> Another interesting think I noticed in pg_dump is dumping of LOBs.  It
> seems to declare a cursor that fetches the blobs and then issues a fetch
> 1000 to get the first 1000 lobs.  It never seems to execute any further
> fetches.  Am I right that if you have more than 1000 lobs in postgres,
> pg_dump won't dump them?

I checked and though the Fetch string is issued outside the loop, it
keeps getting used inside the loop.

There was some strange capitalization that confused things and I cleaned
that up.

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
359-1001+  If your life is a hard drive,     |  13 Roberts Road +  Christ can be your backup.        |  Newtown Square,
Pennsylvania19073