Thread: Re: pgxs: build infrastructure for extensions v4

Peter Eisentraut wrote:
> Am Freitag, 16. Juli 2004 16:34 schrieb Fabien COELHO:
> 
>>Please find attached another new version of a patch which provides a
>>working infrastructure for pg extensions. I hope it addresses all of
>>Peter's comments. I'll be away for the next 3 weeks, so if minor changes
>>are required it would be best if you could proceed without me...
> 
> Done.

I've tested pgxs with PL/R and it allows me to build successfully 
without using a Postgres source tree. Many thanks to both Fabien and 
Peter for this!

One question did arise, however. In order to use pgxs I needed to do:  make install-all-headers
instead of:  make install

I seem to recall some discussion about this, but at the time didn't 
realize the impact. IMHO pgxs support (including all needed headers) 
should be installed by default, else we won't be able to count on it 
being there when needed. Any chance we can revisit this?

Thanks,

Joe

Joe Conway wrote:
> One question did arise, however. In order to use pgxs I needed to do:
>    make install-all-headers
> instead of:
>    make install

Yes, I forgot to mention that the install targets still need to be 
sorted out.  FWIW, I've always been in favor of installing everything 
all the time, even more so now.

-- 
Peter Eisentraut
http://developer.postgresql.org/~petere/

Joe Conway <mail@joeconway.com> writes:
> One question did arise, however. In order to use pgxs I needed to do:
>    make install-all-headers
> instead of:
>    make install

> I seem to recall some discussion about this, but at the time didn't 
> realize the impact. IMHO pgxs support (including all needed headers) 
> should be installed by default, else we won't be able to count on it 
> being there when needed. Any chance we can revisit this?

AFAICS the packagers (RPM etc) will continue to think that these files
belong in a postgresql-devel RPM, and will not include them in a base
package.  I'm not sure of the point of trying to force installation in
a build from source given that much of the world isn't going to be using
a source package anyway.

However, we could certainly talk about altering the default behavior
(eg, install becomes install-no-headers and install-all-headers becomes
part of the default install target).
        regards, tom lane

> However, we could certainly talk about altering the default behavior
> (eg, install becomes install-no-headers and install-all-headers becomes
> part of the default install target).

Seems like a good idea to me.

Chris

Tom Lane wrote:
> Joe Conway <mail@joeconway.com> writes:
> > One question did arise, however. In order to use pgxs I needed to do:
> >    make install-all-headers
> > instead of:
> >    make install
> 
> > I seem to recall some discussion about this, but at the time didn't 
> > realize the impact. IMHO pgxs support (including all needed headers) 
> > should be installed by default, else we won't be able to count on it 
> > being there when needed. Any chance we can revisit this?
> 
> AFAICS the packagers (RPM etc) will continue to think that these files
> belong in a postgresql-devel RPM, and will not include them in a base
> package.  I'm not sure of the point of trying to force installation in
> a build from source given that much of the world isn't going to be using
> a source package anyway.
> 
> However, we could certainly talk about altering the default behavior
> (eg, install becomes install-no-headers and install-all-headers becomes
> part of the default install target).

Agreed.  Added to open items list.

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
359-1001+  If your life is a hard drive,     |  13 Roberts Road +  Christ can be your backup.        |  Newtown Square,
Pennsylvania19073