Thread: Re: [PATCHES] log_line_info
Bruce Momjian wrote: >Andrew Dunstan wrote: > > >>After this is applied (fingers crossed) and everyone is happy, I will >>submit a patch to remove log_timestamp, log_pid and (if we are agreed on >>it) log_source_port. >> >> > >I have applied this patch. It will be a great addition to PostgreSQL. > > > Is there agreement on removing these 3 config vars? cheers andrew
Andrew Dunstan <andrew@dunslane.net> writes:
>>> After this is applied (fingers crossed) and everyone is happy, I will
>>> submit a patch to remove log_timestamp, log_pid and (if we are agreed on
>>> it) log_source_port.
> Is there agreement on removing these 3 config vars?
Now that I look at it, log_source_port does look pretty useless.
While you are at it, please clean up the confusion about whether
port->remote_host contains the port number or not (IMHO it should never
do so; BackendInit() is doing things in the wrong order).
regards, tom lane
> >>After this is applied (fingers crossed) and everyone is happy, I will > >>submit a patch to remove log_timestamp, log_pid and (if we are agreed on > >>it) log_source_port. > Is there agreement on removing these 3 config vars? There is from me.
On Tue, 09 Mar 2004 10:02:14 -0500, Andrew Dunstan <andrew@dunslane.net> wrote: >>>After this is applied (fingers crossed) and everyone is happy, I will >>>submit a patch to remove log_timestamp, log_pid and (if we are agreed on >>>it) log_source_port. >Is there agreement on removing these 3 config vars? Please don't. Declare them obsolete for 7.5 and remove them in a later release. ServusManfred
> Please don't. Declare them obsolete for 7.5 and remove them in a later > release. Nah, just remove them. We've removed, added and changed so many config options and no-one's ever complained... Chris
Christopher Kings-Lynne <chriskl@familyhealth.com.au> writes:
>> Please don't. Declare them obsolete for 7.5 and remove them in a later
>> release.
> Nah, just remove them. We've removed, added and changed so many config
> options and no-one's ever complained...
I agree with Chris; this would be taking compatibility concerns a bit
far. None of these variables are likely to be touched except through
postgresql.conf (I don't think we even allow them to be SET interactively).
And you can never simply take your old .conf file and plop it down into
a new release.
regards, tom lane
Tom Lane wrote: >I agree with Chris; this would be taking compatibility concerns a bit >far. None of these variables are likely to be touched except through >postgresql.conf (I don't think we even allow them to be SET interactively). >And you can never simply take your old .conf file and plop it down into >a new release. > > > Also, I selfishly want to get this out of my hair and move on :-) The docs already state that log_source_port is useless. patch forthcoming soon. cheers andrew
Tom Lane wrote: > Christopher Kings-Lynne <chriskl@familyhealth.com.au> writes: > >> Please don't. Declare them obsolete for 7.5 and remove them in a later > >> release. > > > Nah, just remove them. We've removed, added and changed so many config > > options and no-one's ever complained... > > I agree with Chris; this would be taking compatibility concerns a bit > far. None of these variables are likely to be touched except through > postgresql.conf (I don't think we even allow them to be SET interactively). > And you can never simply take your old .conf file and plop it down into > a new release. And the other reason to remove them is that if you don't, you will get all sorts of confusion about people asking, "Which one should I use for pid logging? Looks like both work." -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001+ If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania19073