Thread: Re: [PATCHES] client_encoding in dump file

Re: [PATCHES] client_encoding in dump file

From
Bruce Momjian
Date:
Pavel Stehule wrote:
> Hello
> 
> I send my first patch for PostgreSQL - maybe ugly patch. This patch 
> generate on top of dump file line with setting of current encoding. Its 
> useful for languages like czech with more than one wide used encoding.
> We need informations about used encoding. 

I found this patch intersting.  How do we deal with restoring a database
with a different encoding from the one dumped.  Does having SET at the
top help?  (Also, we use diff -c.)

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
359-1001+  If your life is a hard drive,     |  13 Roberts Road +  Christ can be your backup.        |  Newtown Square,
Pennsylvania19073
 


Re: [PATCHES] client_encoding in dump file

From
Tom Lane
Date:
Bruce Momjian <pgman@candle.pha.pa.us> writes:
> Pavel Stehule wrote:
>> I send my first patch for PostgreSQL - maybe ugly patch. This patch 
>> generate on top of dump file line with setting of current encoding. Its 
>> useful for languages like czech with more than one wide used encoding.
>> We need informations about used encoding. 

> I found this patch intersting.  How do we deal with restoring a database
> with a different encoding from the one dumped.  Does having SET at the
> top help?  (Also, we use diff -c.)

Yes, the SET should help; it will result in character encoding
translation to whatever the database encoding is.  This has been
discussed before, IIRC.

I was planning to commit this patch (perhaps after cleanup, haven't
looked at it yet) but it's not got to the top of the todo queue...
        regards, tom lane


Re: [PATCHES] client_encoding in dump file

From
Bruce Momjian
Date:
Tom Lane wrote:
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > Pavel Stehule wrote:
> >> I send my first patch for PostgreSQL - maybe ugly patch. This patch 
> >> generate on top of dump file line with setting of current encoding. Its 
> >> useful for languages like czech with more than one wide used encoding.
> >> We need informations about used encoding. 
> 
> > I found this patch intersting.  How do we deal with restoring a database
> > with a different encoding from the one dumped.  Does having SET at the
> > top help?  (Also, we use diff -c.)
> 
> Yes, the SET should help; it will result in character encoding
> translation to whatever the database encoding is.  This has been
> discussed before, IIRC.
> 
> I was planning to commit this patch (perhaps after cleanup, haven't
> looked at it yet) but it's not got to the top of the todo queue...

Thanks. I will just keep it in my mailbox until it is dealt with.

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
359-1001+  If your life is a hard drive,     |  13 Roberts Road +  Christ can be your backup.        |  Newtown Square,
Pennsylvania19073