Thread: Re: [GENERAL] Casting

Re: [GENERAL] Casting

From
Tom Lane
Date:
"Nigel J. Andrews" <nandrews@investsystems.co.uk> writes:
> When I use my cast I get:
> mydb=> select cast('truE'::text as boolean);
> WARNING:  Error occurred while executing PL/pgSQL function text_to_bool
> WARNING:  line 4 at select into variables
> ERROR:  CopyQuerySnapshot: no snapshot has been set

Hmm.  The problem here is that parse_coerce.c thinks it can apply
eval_const_expressions() to simplify the CAST; but in the general case
that doesn't work because the query snapshot may not be set yet.
Had we left the expression to be folded at plan time everything would
be okay.

I dislike removing the optimization altogether, but maybe we don't
have much choice.  Anyone see another way around it?
        regards, tom lane



Re: [GENERAL] Casting

From
"Nigel J. Andrews"
Date:
On Tue, 8 Apr 2003, Tom Lane wrote:

> "Nigel J. Andrews" <nandrews@investsystems.co.uk> writes:
> > When I use my cast I get:
> > mydb=> select cast('truE'::text as boolean);
> > WARNING:  Error occurred while executing PL/pgSQL function text_to_bool
> > WARNING:  line 4 at select into variables
> > ERROR:  CopyQuerySnapshot: no snapshot has been set
> 
> Hmm.  The problem here is that parse_coerce.c thinks it can apply
> eval_const_expressions() to simplify the CAST; but in the general case
> that doesn't work because the query snapshot may not be set yet.
> Had we left the expression to be folded at plan time everything would
> be okay.
> 
> I dislike removing the optimization altogether, but maybe we don't
> have much choice.  Anyone see another way around it?
> 

Well, checking the source, and the comments in there, thanks to Tom's lead I
saw that only immutable functions were folded in the parse. Marking my function
as stable instead of immutable has indeed allowed my test statment above to
run.

So, that could be a published work around, perhaps in the CREATE CAST
page? I'm not sure of the expense of the function being stable and not 
immutable though. I suspect it's most likely not a huge cost for many cases.


-- 
Nigel J. Andrews



Re: [GENERAL] Casting

From
Tom Lane
Date:
"Nigel J. Andrews" <nandrews@investsystems.co.uk> writes:
> So, that could be a published work around, perhaps in the CREATE CAST
> page?

I intend to fix the bug, not publish a workaround ;-)
        regards, tom lane