Thread: cvs-tip broken
n file included from fe-connect.c:24: libpq-int.h:337: warning: `struct timeval' declared inside parameter list libpq-int.h:337: warning: its scope is only this definition or declaration, which is probably not what you want. fe-connect.c: In function `connectDBComplete': fe-connect.c:1060: storage size of `remains' isn't known fe-connect.c:1060: storage size of `finish_time' isn't known fe-connect.c:1060: storage size of `start_time' isn't known fe-connect.c:1081: warning: suggest parentheses around && within || fe-connect.c:1086: warning: implicit declaration of function `gettimeofday' fe-connect.c:1106: warning: passing arg 4 of `pqWaitTimed' from incompatible pointer type fe-connect.c:1114: warning: passing arg 4 of `pqWaitTimed' from incompatible pointer type fe-connect.c:1060: warning: unused variable `start_time' fe-connect.c:1060: warning: unused variable `finish_time' fe-connect.c:1060: warning: unused variable `remains'
I am not seeing the failure here on BSD/OS. I just fixed the libpq-int.h problem. Please update to cvs current and let me know what you see. --------------------------------------------------------------------------- Rod Taylor wrote: > n file included from fe-connect.c:24: > libpq-int.h:337: warning: `struct timeval' declared inside parameter > list > libpq-int.h:337: warning: its scope is only this definition or > declaration, which is probably not what you want. > fe-connect.c: In function `connectDBComplete': > fe-connect.c:1060: storage size of `remains' isn't known > fe-connect.c:1060: storage size of `finish_time' isn't known > fe-connect.c:1060: storage size of `start_time' isn't known > fe-connect.c:1081: warning: suggest parentheses around && within || > fe-connect.c:1086: warning: implicit declaration of function > `gettimeofday' > fe-connect.c:1106: warning: passing arg 4 of `pqWaitTimed' from > incompatible pointer type > fe-connect.c:1114: warning: passing arg 4 of `pqWaitTimed' from > incompatible pointer type > fe-connect.c:1060: warning: unused variable `start_time' > fe-connect.c:1060: warning: unused variable `finish_time' > fe-connect.c:1060: warning: unused variable `remains' > > > > > > ---------------------------(end of broadcast)--------------------------- > TIP 3: if posting/reading through Usenet, please send an appropriate > subscribe-nomail command to majordomo@postgresql.org so that your > message can get through to the mailing list cleanly > -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001+ If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania19073
Bruce Momjian <pgman@candle.pha.pa.us> writes:
> I am not seeing the failure here on BSD/OS. I just fixed the
> libpq-int.h problem. Please update to cvs current and let me know what
> you see.
FWIW, libpq seems to build fine here (HPUX 10.20) both before and after
your latest commit. Rod should probably mention what platform he's
using, and where it defines struct timeval...
regards, tom lane
The code was clearly wrong, mentioning timeval with no time.h nor sys/types.h include. My patches should fix him [good]. :-) Who used to say, "I will fix him good"? I don't remember. --------------------------------------------------------------------------- Tom Lane wrote: > Bruce Momjian <pgman@candle.pha.pa.us> writes: > > I am not seeing the failure here on BSD/OS. I just fixed the > > libpq-int.h problem. Please update to cvs current and let me know what > > you see. > > FWIW, libpq seems to build fine here (HPUX 10.20) both before and after > your latest commit. Rod should probably mention what platform he's > using, and where it defines struct timeval... > > regards, tom lane > > ---------------------------(end of broadcast)--------------------------- > TIP 5: Have you checked our extensive FAQ? > > http://www.postgresql.org/users-lounge/docs/faq.html > -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001+ If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania19073
On Sat, 2002-08-17 at 22:08, Tom Lane wrote: > Bruce Momjian <pgman@candle.pha.pa.us> writes: > > I am not seeing the failure here on BSD/OS. I just fixed the > > libpq-int.h problem. Please update to cvs current and let me know what > > you see. > > FWIW, libpq seems to build fine here (HPUX 10.20) both before and after > your latest commit. Rod should probably mention what platform he's > using, and where it defines struct timeval... I still have to wait another 30 minutes before I can update to the latest revision, but here's what's needed: bash-2.05b$ uname -a FreeBSD jester 4.6-RELEASE FreeBSD 4.6-RELEASE #8: Fri Jul 19 23:45:16 EDT 2002 root@jester:/usr/obj/usr/src/sys/JESTER i386
Attachment
I think I added time.h and sys/types.h. That should do it for you. --------------------------------------------------------------------------- Rod Taylor wrote: > On Sat, 2002-08-17 at 22:08, Tom Lane wrote: > > Bruce Momjian <pgman@candle.pha.pa.us> writes: > > > I am not seeing the failure here on BSD/OS. I just fixed the > > > libpq-int.h problem. Please update to cvs current and let me know what > > > you see. > > > > FWIW, libpq seems to build fine here (HPUX 10.20) both before and after > > your latest commit. Rod should probably mention what platform he's > > using, and where it defines struct timeval... > > I still have to wait another 30 minutes before I can update to the > latest revision, but here's what's needed: > > > bash-2.05b$ uname -a > FreeBSD jester 4.6-RELEASE FreeBSD 4.6-RELEASE #8: Fri Jul 19 23:45:16 > EDT 2002 root@jester:/usr/obj/usr/src/sys/JESTER i386 > > [ Attachment, skipping... ] -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001+ If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania19073
On Sat, 2002-08-17 at 22:44, Bruce Momjian wrote: > > I think I added time.h and sys/types.h. That should do it for you. Hmm.. whelp, the file in question on FreeBSD is sys/time.h (attached earlier) so this won't fix it. > --------------------------------------------------------------------------- > > Rod Taylor wrote: > > On Sat, 2002-08-17 at 22:08, Tom Lane wrote: > > > Bruce Momjian <pgman@candle.pha.pa.us> writes: > > > > I am not seeing the failure here on BSD/OS. I just fixed the > > > > libpq-int.h problem. Please update to cvs current and let me know what > > > > you see. > > > > > > FWIW, libpq seems to build fine here (HPUX 10.20) both before and after > > > your latest commit. Rod should probably mention what platform he's > > > using, and where it defines struct timeval... > > > > I still have to wait another 30 minutes before I can update to the > > latest revision, but here's what's needed: > > > > > > bash-2.05b$ uname -a > > FreeBSD jester 4.6-RELEASE FreeBSD 4.6-RELEASE #8: Fri Jul 19 23:45:16 > > EDT 2002 root@jester:/usr/obj/usr/src/sys/JESTER i386 > > > > > > [ Attachment, skipping... ] > > -- > Bruce Momjian | http://candle.pha.pa.us > pgman@candle.pha.pa.us | (610) 359-1001 > + If your life is a hard drive, | 13 Roberts Road > + Christ can be your backup. | Newtown Square, Pennsylvania 19073 > > ---------------------------(end of broadcast)--------------------------- > TIP 3: if posting/reading through Usenet, please send an appropriate > subscribe-nomail command to majordomo@postgresql.org so that your > message can get through to the mailing list cleanly >
Rod Taylor <rbt@zort.ca> writes:
> Hmm.. whelp, the file in question on FreeBSD is sys/time.h (attached
> earlier) so this won't fix it.
Added #include <sys/time.h>. We seem to use this unconditionally in
many other files, so I don't see a reason not to include it here.
regards, tom lane