Thread: Is contrib/rserv/Makefile broken?

Is contrib/rserv/Makefile broken?

From
Satoshi Nagayasu
Date:
Hi all,

In 7.2.1, MasterInit script (rserv command) does not work correctly,
because $libdir is not defined in it.

I think $libdir should be replaced in Makefile as below.

Is it correct?

--- Makefile    Mon Mar 11 13:39:14 2002
+++ /tmp/Makefile       Tue Aug 13 18:19:21 2002
@@ -22,10 +22,10 @@all: $(SQLS) $(TCLS) $(PERLS) $(SCRIPTS) $(SONAME)%.sql: %.sql.in
-       sed 's,@MODULE_FILENAME@,$$libdir/$(NAME),g' $< >$@
+       sed 's,@MODULE_FILENAME@,$(libdir)/$(NAME),g' $< >$@$(PERLS) $(TCLS) $(SCRIPTS): %: %.in
-       sed -e 's,@MODULE_FILENAME@,$$libdir/$(NAME),g' \
+       sed -e 's,@MODULE_FILENAME@,$(libdir)/$(NAME),g' \           -e 's:@SQLDIR@:$(datadir)/contrib:g' \
-e's:@BINDIR@:$(bindir):g' \           -e 's:@LIBDIR@:$(datadir)/contrib:g' $< >$@
 

-- 
NAGAYASU Satoshi <snaga@snaga.org>


Re: Is contrib/rserv/Makefile broken?

From
Peter Eisentraut
Date:
Satoshi Nagayasu writes:

> I think $libdir should be replaced in Makefile as below.

No, it's correct as is.  Read the documentation.

-- 
Peter Eisentraut   peter_e@gmx.net