Thread: Re: regression test failure

Re: regression test failure

From
Tatsuo Ishii
Date:
[Cced to hackers list]

> I'm seeing a regression test failure with the latest CVS code, in the
> 'conversion' test. I've attached the 'regression.diff' file -- the
> failure occurs consistently on my machine.
> 
> I'm mailing you because I believe the test in question is for code you
> wrote). Let me know if you need any more information.

Do you still have the failure after doing "make install"? If so, it's
news to me.

If not, it's a known problem I want to fix before the beta freeze. The
basic problem here is I'm using following statement while doing
initdb:

CREATE OR REPLACE FUNCTION utf8_to_iso8859_1 (INTEGER, INTEGER,
OPAQUE, OPAQUE, INTEGER) RETURNS INTEGER AS
'$libdir/utf8_and_iso8859_1', 'utf8_to_iso8859_1' LANGUAGE 'c';

The $libdir variable is defined at the compile time and it points to
$prefix/lib. Apparently it points to different place while doing
regression tests. One idea is replacing $lindir with the absolute path
to $prefix/lib. However I wonder this would break some installations,
for example RPM.

Any idea?
--
Tatsuo Ishii


Re: regression test failure

From
Peter Eisentraut
Date:
Tatsuo Ishii writes:

> The $libdir variable is defined at the compile time and it points to
> $prefix/lib. Apparently it points to different place while doing
> regression tests. One idea is replacing $lindir with the absolute path
> to $prefix/lib. However I wonder this would break some installations,
> for example RPM.

You can replace the string '$libdir' in the conversions_create.sql file
with an absolute directory name during the standalone regression test run.
This could be done in the regression test driver, where the correct path
is available as $pkglibdir.  Other, less messy solutions don't occur to me
offhand.

-- 
Peter Eisentraut   peter_e@gmx.net



Re: regression test failure

From
Lamar Owen
Date:
On Tuesday 13 August 2002 03:52 pm, Peter Eisentraut wrote:
> Tatsuo Ishii writes:
> > The $libdir variable is defined at the compile time and it points to
> > $prefix/lib. Apparently it points to different place while doing
> > regression tests. One idea is replacing $lindir with the absolute path
> > to $prefix/lib. However I wonder this would break some installations,
> > for example RPM.

> You can replace the string '$libdir' in the conversions_create.sql file
> with an absolute directory name during the standalone regression test run.
> This could be done in the regression test driver, where the correct path
> is available as $pkglibdir.  Other, less messy solutions don't occur to me
> offhand.

The RPM's patch the regression tests to work -- in a somewhat broken way, but 
enough to get useful results.  IIRC, I'm already subbing $libdir out in them.
-- 
Lamar Owen
WGCR Internet Radio
1 Peter 4:11