Thread: Typo in htup.h comment
Fix typo in xl_heaptid comment
ServusManfred
--- ../base/src/include/access/htup.h 2002-07-04 18:05:04.000000000 +0200
+++ src/include/access/htup.h 2002-07-05 16:52:44.000000000 +0200
@@ -268,15 +268,15 @@/* * When we insert 1st item on new page in INSERT/UPDATE * we can (and we do) restore entire page
inredo */#define XLOG_HEAP_INIT_PAGE 0x80/*
- * All what we need to find changed tuple (18 bytes)
+ * All what we need to find changed tuple (14 bytes) * * NB: on most machines, sizeof(xl_heaptid) will include some
trailingpad * bytes for alignment. We don't want to store the pad space in the XLOG, * so use SizeOfHeapTid for space
calculations. Similar comments apply for * the other xl_FOO structs. */typedef struct xl_heaptid{ RelFileNode node;
ItemPointerData tid; /* changed tuple id */} xl_heaptid;
ServusManfred
Your patch has been added to the PostgreSQL unapplied patches list at: http://candle.pha.pa.us/cgi-bin/pgpatches I will try to apply it within the next 48 hours. --------------------------------------------------------------------------- Manfred Koizar wrote: > Fix typo in xl_heaptid comment > > Servus > Manfred > > --- ../base/src/include/access/htup.h 2002-07-04 18:05:04.000000000 +0200 > +++ src/include/access/htup.h 2002-07-05 16:52:44.000000000 +0200 > @@ -268,15 +268,15 @@ > /* > * When we insert 1st item on new page in INSERT/UPDATE > * we can (and we do) restore entire page in redo > */ > #define XLOG_HEAP_INIT_PAGE 0x80 > > /* > - * All what we need to find changed tuple (18 bytes) > + * All what we need to find changed tuple (14 bytes) > * > * NB: on most machines, sizeof(xl_heaptid) will include some trailing pad > * bytes for alignment. We don't want to store the pad space in the XLOG, > * so use SizeOfHeapTid for space calculations. Similar comments apply for > * the other xl_FOO structs. > */ > typedef struct xl_heaptid > { > RelFileNode node; > ItemPointerData tid; /* changed tuple id */ > } xl_heaptid; > > Servus > Manfred > > > > ---------------------------(end of broadcast)--------------------------- > TIP 1: subscribe and unsubscribe commands go to majordomo@postgresql.org > > > -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 853-3000+ If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania19026
Patch applied. Thanks.
---------------------------------------------------------------------------
Manfred Koizar wrote:
> Fix typo in xl_heaptid comment
>
> Servus
> Manfred
>
> --- ../base/src/include/access/htup.h 2002-07-04 18:05:04.000000000 +0200
> +++ src/include/access/htup.h 2002-07-05 16:52:44.000000000 +0200
> @@ -268,15 +268,15 @@
> /*
> * When we insert 1st item on new page in INSERT/UPDATE
> * we can (and we do) restore entire page in redo
> */
> #define XLOG_HEAP_INIT_PAGE 0x80
>
> /*
> - * All what we need to find changed tuple (18 bytes)
> + * All what we need to find changed tuple (14 bytes)
> *
> * NB: on most machines, sizeof(xl_heaptid) will include some trailing pad
> * bytes for alignment. We don't want to store the pad space in the XLOG,
> * so use SizeOfHeapTid for space calculations. Similar comments apply for
> * the other xl_FOO structs.
> */
> typedef struct xl_heaptid
> {
> RelFileNode node;
> ItemPointerData tid; /* changed tuple id */
> } xl_heaptid;
>
> Servus
> Manfred
>
>
>
> ---------------------------(end of broadcast)---------------------------
> TIP 1: subscribe and unsubscribe commands go to majordomo@postgresql.org
>
>
>
-- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610)
853-3000+ If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill,
Pennsylvania19026