Thread: Always the same ecpg bug - please (re)apply patch
Here is the description:
When a macro is replaced by the preprocessor, pgc.l reaches a end of file, which is not the actual end of the file. One side effect of that is that if you are in a ifdef block, you get a wrong error telling you that a endif is missing.
This patch corrects pgc.l and also adds a test of this problem to test1.pgc. To convince you apply the patch to test1.pgc first then try to compile the test then apply the patch to pgc.l.
The patch moves the test of the scope of an ifdef block to the end of the file beeing parsed, including all includes files, ... .
For the record, this patch was applied a first time by bruce then overwritten by Micheal and reapplied by him. But the big mystery is that there is no trace of that in CVS ????
Nicolas
Attachment
Your patch has been added to the PostgreSQL unapplied patches list at: http://candle.pha.pa.us/cgi-bin/pgpatches I will try to apply it within the next 48 hours. --------------------------------------------------------------------------- Nicolas Bazin wrote: > Here is the description: > > When a macro is replaced by the preprocessor, pgc.l reaches a end of file, which is not the actual end of the file. Oneside effect of that is that if you are in a ifdef block, you get a wrong error telling you that a endif is missing. > > This patch corrects pgc.l and also adds a test of this problem to test1.pgc. To convince you apply the patch to test1.pgcfirst then try to compile the test then apply the patch to pgc.l. > > The patch moves the test of the scope of an ifdef block to the end of the file beeing parsed, including all includes files,... . > > For the record, this patch was applied a first time by bruce then overwritten by Micheal and reapplied by him. But thebig mystery is that there is no trace of that in CVS ???? > > Nicolas [ Attachment, skipping... ] -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 853-3000+ If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania19026
Patch applied. Thanks. --------------------------------------------------------------------------- Nicolas Bazin wrote: > Here is the description: > > When a macro is replaced by the preprocessor, pgc.l reaches a end of file, which is not the actual end of the file. Oneside effect of that is that if you are in a ifdef block, you get a wrong error telling you that a endif is missing. > > This patch corrects pgc.l and also adds a test of this problem to test1.pgc. To convince you apply the patch to test1.pgcfirst then try to compile the test then apply the patch to pgc.l. > > The patch moves the test of the scope of an ifdef block to the end of the file beeing parsed, including all includes files,... . > > For the record, this patch was applied a first time by bruce then overwritten by Micheal and reapplied by him. But thebig mystery is that there is no trace of that in CVS ???? > > Nicolas [ Attachment, skipping... ] -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 853-3000+ If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania19026