Postgres Pro
Downloads
Home   >   mailing lists

Thread: Re: [SQL] An easy question about creating a primary key

Re: [SQL] An easy question about creating a primary key

From
Tom Lane
Date:
"Christopher Kings-Lynne" <chriskl@familyhealth.com.au> writes:
> Oh well, it was a fun coding exercise ;)  Feel free to remove the ADD UNIQUE
> stuff from command.c to see if the parser will handle it.  However, your
> commit message also just implies that all you fixed was ADD PRIMARY KEY???

It says that because I thought that was all I was changing; I hadn't
realized the side-effects on ADD UNIQUE.
        regards, tom lane

Re: [SQL] An easy question about creating a primary key

From
Bruce Momjian
Date:
Is this resolved?

---------------------------------------------------------------------------

> "Christopher Kings-Lynne" <chriskl@familyhealth.com.au> writes:
> > Oh well, it was a fun coding exercise ;)  Feel free to remove the ADD UNIQUE
> > stuff from command.c to see if the parser will handle it.  However, your
> > commit message also just implies that all you fixed was ADD PRIMARY KEY???
> 
> It says that because I thought that was all I was changing; I hadn't
> realized the side-effects on ADD UNIQUE.

--  Bruce Momjian                        |  http://candle.pha.pa.us pgman@candle.pha.pa.us               |  (610)
853-3000+  If your life is a hard drive,     |  830 Blythe Avenue +  Christ can be your backup.        |  Drexel Hill,
Pennsylvania19026

Re: [SQL] An easy question about creating a primary key

From
Tom Lane
Date:
Bruce Momjian <pgman@candle.pha.pa.us> writes:
> Is this resolved?

Yup, the no-longer-needed code is gone.
        regards, tom lane

Re: [SQL] An easy question about creating a primary key

From
"Christopher Kings-Lynne"
Date:
Note that although I added a regression test for ADD UNIQUE (and had some
confusion as it was Tom's error messages generated, not mine!), I didn't add
an ADD PRIMARY KEY one.  It should be done in 7.3 I guess.

Chris

> -----Original Message-----
> From: Bruce Momjian [mailto:pgman@candle.pha.pa.us]
> Sent: Friday, 28 December 2001 1:11 PM
> To: Tom Lane
> Cc: Christopher Kings-Lynne; Ligia Pimentel; Hackers
> Subject: Re: [HACKERS] [SQL] An easy question about creating a primary
> key
>
>
>
> Is this resolved?
>
> ------------------------------------------------------------------
> ---------
>
> > "Christopher Kings-Lynne" <chriskl@familyhealth.com.au> writes:
> > > Oh well, it was a fun coding exercise ;)  Feel free to remove
> the ADD UNIQUE
> > > stuff from command.c to see if the parser will handle it.
> However, your
> > > commit message also just implies that all you fixed was ADD
> PRIMARY KEY???
> >
> > It says that because I thought that was all I was changing; I hadn't
> > realized the side-effects on ADD UNIQUE.
>
> --
>   Bruce Momjian                        |  http://candle.pha.pa.us
>   pgman@candle.pha.pa.us               |  (610) 853-3000
>   +  If your life is a hard drive,     |  830 Blythe Avenue
>   +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026
>