Thread: Re: Open Items (was: RE: [HACKERS] Beta going well)

Re: Open Items (was: RE: [HACKERS] Beta going well)

From
"Zeugswetter Andreas SB SD"
Date:
> The check for int64 and uint64 has to be separated, my AIX
> has: int8, int16, int32, int64
> but not: uint8, uint16, uint32, uint64

This would be an incremental patch to Peter's, but as I said I have not
been able to check configure itself. (The rest works, needless to say)
I am actually very suspicious whether the configure trick
AC_CHECK_SIZEOF(int8, 0) will work, because they only get defined
with _ALL_SOURCE defined and inttypes.h included.

Previous patch included just in case.
Tatsuo would you be so kind as to check this, that would be great ?

Andreas

Attachment

Re: Open Items (was: RE: [HACKERS] Beta going well)

From
Tatsuo Ishii
Date:
> > The check for int64 and uint64 has to be separated, my AIX
> > has: int8, int16, int32, int64
> > but not: uint8, uint16, uint32, uint64
>
> This would be an incremental patch to Peter's, but as I said I have not
> been able to check configure itself. (The rest works, needless to say)
> I am actually very suspicious whether the configure trick
> AC_CHECK_SIZEOF(int8, 0) will work, because they only get defined
> with _ALL_SOURCE defined and inttypes.h included.
>
> Previous patch included just in case.
> Tatsuo would you be so kind as to check this, that would be great ?

Peter's patches could not be applied to the current and I cannot test
your patches too.

[t-ishii@srapc1474 pgsql]$ patch -b -p2 < ~/int8-patch
missing header for context diff at line 3 of patch
patching file configure.in
patching file src/include/pg_config.h.in
patching file src/include/c.h
Hunk #1 FAILED at 204.
Hunk #2 FAILED at 216.
Hunk #3 FAILED at 266.
3 out of 3 hunks FAILED -- saving rejects to file src/include/c.h.rej
--
Tatsuo Ishii