Thread: pg_dump -C option
All,
I am working a some patches to the code and I noticed that "pg_dump -C
database" doesn't provide the database location information in the dump
file. Is this correct?
Thanks
Jim
Example:
datname | datdba | encoding | datistemplate | datallowconn |
datlastsysoid | datpath | idxpath
-----------+--------+----------+---------------+--------------+---------------+---------+---------jb1 | 5433 |
0 | f | t |
18540 | | PGIDX1template1 | 5433 | 0 | t | t |
18540 | | template0 | 5433 | 0 | t | f |
18540 | | jb2 | 5433 | 0 | f | t |
18540 | PGDATA1 | PGIDX1jb3 | 5433 | 0 | f | t |
18540 | PGDATA1 | 4051 | 5433 | 0 | f | t |
18540 | PGDATA1 | PGIDX1
(Please ignore the IDXPATH column for now as I am trying to add support
for INDEX locations as I am running out of room on my current system and
I don't like the "symlink your own tables/index files" idea)
and the output of pg_dump -C
--
-- Selected TOC Entries:
--
\connect - pgtest
--
-- TOC Entry ID 1 (OID 0)
--
-- Name: jb2 Type: DATABASE Owner: pgtest
--
Create Database "jb2";
\connect jb2 pgtest
Jim Buttafuoco writes: > I am working a some patches to the code and I noticed that "pg_dump -C > database" doesn't provide the database location information in the dump > file. Is this correct? Your observation is correct, but the behaviour is not. Feel free to send a patch. -- Peter Eisentraut peter_e@gmx.net http://funkturm.homeip.net/~peter
will do. > Jim Buttafuoco writes: > > > I am working a some patches to the code and I noticed that "pg_dump -C > > database" doesn't provide the database location information in the dump > > file. Is this correct? > > Your observation is correct, but the behaviour is not. Feel free to > send a patch. > > -- > Peter Eisentraut peter_e@gmx.net http://funkturm.homeip.net/~peter > > > ---------------------------(end of broadcast)--------------------------- > TIP 1: subscribe and unsubscribe commands go to majordomo@postgresql.org > >
Jim Buttafuoco writes: > will do. While you're at it, at least the encoding parameter should be saved as well. Take a peek at what pg_dumpall saves. > > > > > Jim Buttafuoco writes: > > > > > I am working a some patches to the code and I noticed that "pg_dump > -C > > > database" doesn't provide the database location information in the > dump > > > file. Is this correct? > > > > Your observation is correct, but the behaviour is not. Feel free to > > send a patch. > > > > -- > > Peter Eisentraut peter_e@gmx.net http://funkturm.homeip.net/~peter > > > > > > ---------------------------(end of > broadcast)--------------------------- > > TIP 1: subscribe and unsubscribe commands go to > majordomo@postgresql.org > > > > > > > -- Peter Eisentraut peter_e@gmx.net http://funkturm.homeip.net/~peter
Added to TODO: * Have pg_dump -C dump database location and encoding information > Jim Buttafuoco writes: > > > will do. > > While you're at it, at least the encoding parameter should be saved as > well. Take a peek at what pg_dumpall saves. > > > > > > > > > > Jim Buttafuoco writes: > > > > > > > I am working a some patches to the code and I noticed that "pg_dump > > -C > > > > database" doesn't provide the database location information in the > > dump > > > > file. Is this correct? > > > > > > Your observation is correct, but the behaviour is not. Feel free to > > > send a patch. > > > > > > -- > > > Peter Eisentraut peter_e@gmx.net http://funkturm.homeip.net/~peter > > > > > > > > > ---------------------------(end of > > broadcast)--------------------------- > > > TIP 1: subscribe and unsubscribe commands go to > > majordomo@postgresql.org > > > > > > > > > > > > > > -- > Peter Eisentraut peter_e@gmx.net http://funkturm.homeip.net/~peter > > > ---------------------------(end of broadcast)--------------------------- > TIP 6: Have you searched our list archives? > > http://www.postgresql.org/search.mpl > -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 853-3000+ If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania19026