Thread: Inline Comments for pg_dump
I've very roughly (first time I've tried anything but hello world c) hacked up inline comments.
pg_dump -I
Exports the comments generated through COMMENT ON in an appropriate manner (line above) the item with a -- in front. More or less a self documenting dump, or atleast an attempt at it.
However, due to my poor programming in this language, I'm not sure of teh best way to handle the issues following:
- Column comments mis-format the next row (Needs a \t or something)
- Database comments non-existent, wasn't sure how or where to pull them out.
- I've only tested TABLE and COLUMN comments. Didn't have a database handy with the rest, and had a limited amount of time to fiddle.
Take a look and see if it's worth anything or if it needs to be fixed up.
--
Rod Taylor
Rod Taylor
There are always four sides to every story: your side, their side, the truth, and what really happened.
Attachment
We are already in beta, so I don't think I can apply this. I will keep it and apply in our 7.2 development tree. [ Charset ISO-8859-1 unsupported, converting... ] > I've very roughly (first time I've tried anything but hello world c) hacked up inline comments. > > pg_dump -I > > Exports the comments generated through COMMENT ON in an appropriate manner (line above) the item with a -- in front. Moreor less a self documenting dump, or atleast an attempt at it. > > However, due to my poor programming in this language, I'm not sure of teh best way to handle the issues following: > - Column comments mis-format the next row (Needs a \t or something) > - Database comments non-existent, wasn't sure how or where to pull them out. > - I've only tested TABLE and COLUMN comments. Didn't have a database handy with the rest, and had a limited amount oftime to fiddle. > > Take a look and see if it's worth anything or if it needs to be fixed up. > -- > Rod Taylor > > There are always four sides to every story: your side, their side, the truth, and what really happened. [ Attachment, skipping... ] [ Attachment, skipping... ] -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 853-3000+ If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania19026
Believe it or not, I was just about to start working on comment support (by practicing in phpPgAdmin, so I'm happy to look over the code to see if I can address the issues raised, and maybe to do it for all database objects...? Chris > -----Original Message----- > From: pgsql-hackers-owner@postgresql.org > [mailto:pgsql-hackers-owner@postgresql.org]On Behalf Of Bruce Momjian > Sent: Friday, December 22, 2000 3:17 AM > To: Rod Taylor > Cc: pgsql-hackers@postgresql.org > Subject: Re: [HACKERS] Inline Comments for pg_dump > > > We are already in beta, so I don't think I can apply this. I will keep > it and apply in our 7.2 development tree. > > > [ Charset ISO-8859-1 unsupported, converting... ] > > I've very roughly (first time I've tried anything but hello > world c) hacked up inline comments. > > > > pg_dump -I > > > > Exports the comments generated through COMMENT ON in an > appropriate manner (line above) the item with a -- in front. > More or less a self documenting dump, or atleast an attempt at it. > > > > However, due to my poor programming in this language, I'm not > sure of teh best way to handle the issues following: > > - Column comments mis-format the next row (Needs a \t or something) > > - Database comments non-existent, wasn't sure how or where to > pull them out. > > - I've only tested TABLE and COLUMN comments. Didn't have a > database handy with the rest, and had a limited amount of time to fiddle. > > > > Take a look and see if it's worth anything or if it needs to be > fixed up. > > -- > > Rod Taylor > > > > There are always four sides to every story: your side, their > side, the truth, and what really happened. > > [ Attachment, skipping... ] > > [ Attachment, skipping... ] > > > -- > Bruce Momjian | http://candle.pha.pa.us > pgman@candle.pha.pa.us | (610) 853-3000 > + If your life is a hard drive, | 830 Blythe Avenue > + Christ can be your backup. | Drexel Hill, Pennsylvania 19026 >
Can someone remind me what happened to this issue? [ Charset ISO-8859-1 unsupported, converting... ] > I've very roughly (first time I've tried anything but hello world c) hacked up inline comments. > > pg_dump -I > > Exports the comments generated through COMMENT ON in an appropriate manner (line above) the item with a -- in front. Moreor less a self documenting dump, or atleast an attempt at it. > > However, due to my poor programming in this language, I'm not sure of teh best way to handle the issues following: > - Column comments mis-format the next row (Needs a \t or something) > - Database comments non-existent, wasn't sure how or where to pull them out. > - I've only tested TABLE and COLUMN comments. Didn't have a database handy with the rest, and had a limited amount oftime to fiddle. > > Take a look and see if it's worth anything or if it needs to be fixed up. > -- > Rod Taylor > > There are always four sides to every story: your side, their side, the truth, and what really happened. [ Attachment, skipping... ] [ Attachment, skipping... ] -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 853-3000+ If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania19026
Do we handle COMMENT properly in pg_dump now already? [ Charset ISO-8859-1 unsupported, converting... ] > I've very roughly (first time I've tried anything but hello world c) hacked up inline comments. > > pg_dump -I > > Exports the comments generated through COMMENT ON in an appropriate manner (line above) the item with a -- in front. Moreor less a self documenting dump, or atleast an attempt at it. > > However, due to my poor programming in this language, I'm not sure of teh best way to handle the issues following: > - Column comments mis-format the next row (Needs a \t or something) > - Database comments non-existent, wasn't sure how or where to pull them out. > - I've only tested TABLE and COLUMN comments. Didn't have a database handy with the rest, and had a limited amount oftime to fiddle. > > Take a look and see if it's worth anything or if it needs to be fixed up. > -- > Rod Taylor > > There are always four sides to every story: your side, their side, the truth, and what really happened. [ Attachment, skipping... ] [ Attachment, skipping... ] -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 853-3000+ If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania19026