Thread: Re: [COMMITTERS] pgsql/contrib/pg_dumplo (README.pg_dumplo lo_export.c lo_import.c main.c pg_dumplo.h utils.c)
Re: [COMMITTERS] pgsql/contrib/pg_dumplo (README.pg_dumplo lo_export.c lo_import.c main.c pg_dumplo.h utils.c)
From
Peter Eisentraut
Date:
tgl@postgresql.org writes: > Date: Tuesday, November 21, 2000 @ 19:00:55 > Author: tgl > > Update of /home/projects/pgsql/cvsroot/pgsql/contrib/pg_dumplo > from hub.org:/home/projects/pgsql/tmp/cvs-serv39905 > > Modified Files: > README.pg_dumplo lo_export.c lo_import.c main.c pg_dumplo.h > utils.c > > ----------------------------- Log Message ----------------------------- > > Code review: minor cleanups, make the world safe for unsigned OIDs. > Improve documentation, too. Doesn't pg_dump handle large objects these days? -- Peter Eisentraut peter_e@gmx.net http://yi.org/peter-e/
Re: [COMMITTERS] pgsql/contrib/pg_dumplo (README.pg_dumplo lo_export.c lo_import.c main.c pg_dumplo.h utils.c)
From
Tom Lane
Date:
Peter Eisentraut <peter_e@gmx.net> writes: > tgl@postgresql.org writes: >> Modified Files: >> README.pg_dumplo lo_export.c lo_import.c main.c pg_dumplo.h >> utils.c >> >> Code review: minor cleanups, make the world safe for unsigned OIDs. >> Improve documentation, too. > Doesn't pg_dump handle large objects these days? It does, so pg_dumplo is probably dead code --- for people running 7.1 or later. The reason I'm taking an interest in it is that Great Bridge wants to make it available to people running 6.5.* or 7.0.*, so that they can get their large objects into newer versions in the first place. Also, it's possible that someone using pg_dumplo would not want to change (though I'm not sure why not). So we probably oughta leave it in the distro for a version or three anyway. regards, tom lane