Thread: Removing src/backend from include path might break on HPUX

Removing src/backend from include path might break on HPUX

From
Peter Eisentraut
Date:
Now that we don't -I...backend anymore, this might break:

src/include/c.h:

#ifdef FIXADE
#if defined(hpux)
#include "port/hpux/fixade.h"   /* for unaligned access fixup */
#endif   /* hpux */
#endif

The comments surrounding this make it pretty unclear whether this is still
necessary. Tom, any idea?


-- 
Peter Eisentraut                  Sernanders väg 10:115
peter_e@gmx.net                   75262 Uppsala
http://yi.org/peter-e/            Sweden



Re: Removing src/backend from include path might break on HPUX

From
Tom Lane
Date:
Peter Eisentraut <peter_e@gmx.net> writes:
> Now that we don't -I...backend anymore, this might break:
> src/include/c.h:

> #ifdef FIXADE
> #if defined(hpux)
> #include "port/hpux/fixade.h"   /* for unaligned access fixup */
> #endif   /* hpux */
> #endif

> The comments surrounding this make it pretty unclear whether this is still
> necessary. Tom, any idea?

FIXADE is not defined on the normal HPUX build, so it's a non-issue as
far as I know.  AFAICT this file dates back to Berkeley days and exists
only to work around HP compiler bugs that existed about ten years ago.
We don't support HPUX <= 9.01 anymore anyway; there are plenty of other
reasons not to.

I have been planning for some time to nuke fixade.h, but haven't got
round to it.  Be my guest (and don't forget to zap the reference to it
in src/backend/Makefile's install stuff too.  AFAICT we don't need to
make an installed include/port subdirectory at all anymore...)

BTW, there are a couple of other templates that define NOFIXADE, which
seems to be something completely different; don't mistake it as being
the inverse of FIXADE.
        regards, tom lane