Thread: Re: [GENERAL] Version 7.0 beta problem

Re: [GENERAL] Version 7.0 beta problem

From
Peter Eisentraut
Date:
Mark Jewiss writes:

> 04:25pm mark@mark:~/src/pgsql/src/bin/psql $ sudo gmake
[snip]
> gcc -I../../interfaces/libpq -I../../include -I../../backend   -O2 -pipe -Wall -Wmissing-prototypes
-Wmissing-declarations  -c mainloop.c -o mainloop.o
 
> mainloop.c: In function `MainLoop':
> mainloop.c:43: warning: variable `successResult' might be clobbered by `longjmp' or `vfork'
> mainloop.c:44: warning: variable `slashCmdStatus' might be clobbered by `longjmp' or `vfork'
> mainloop.c:47: warning: variable `in_quote' might be clobbered by `longjmp' or `vfork'
[etc]

I thought I had shut up those warnings by making the variables in question
volatile. There's no need to worry about them since they're re-initialized
right after the longjmp, but does anyone know how to shut up the compiler?

> gcc -I../../interfaces/libpq -I../../include -I../../backend   -O2 -pipe
> -Wall -
> Wmissing-prototypes -Wmissing-declarations   -c tab-complete.c -o
> tab-complete.o
> tab-complete.c: In function `psql_completion':
> tab-complete.c:535: `filename_completion_function' undeclared (first use
> in this
>  function)
> tab-complete.c:535: (Each undeclared identifier is reported only once
> tab-complete.c:535: for each function it appears in.)
> gmake: *** [tab-complete.o] Error 1
> 04:25pm mark@mark:~/src/pgsql/src/bin/psql $ 

Aye, there's the rub. One more of these and I'm yanking every trace of
readline out of psql. ;) Another configure test, another subtle functional
difference as the consequence ...

-- 
Peter Eisentraut                  Sernanders väg 10:115
peter_e@gmx.net                   75262 Uppsala
http://yi.org/peter-e/            Sweden



Re: [HACKERS] Re: [GENERAL] Version 7.0 beta problem

From
Tom Lane
Date:
Peter Eisentraut <peter_e@gmx.net> writes:
> Mark Jewiss writes:
>> mainloop.c:43: warning: variable `successResult' might be clobbered by `longjmp' or `vfork'

> I thought I had shut up those warnings by making the variables in question
> volatile. There's no need to worry about them since they're re-initialized
> right after the longjmp, but does anyone know how to shut up the compiler?

That *should* shut up these warnings.  Maybe Mark is trying a slightly
back-dated beta version?  I know you didn't have the "volatile"s in
there a few days ago.
        regards, tom lane