Thread: Re: [HACKERS] Current source from CVS won't compile.

Yes.

This is my fault. Sorry.  Attached is a patch which fixes the problem.
I missed adding the rule to make parse.h to the Makefile for
the ../backend/commands. It also allows for comments to be dropped
using IS NULL as well as IS '';

Again, sorry.

Mike Mascari
(mascarim@yahoo.com)

--- Keith Parks <emkxp01@mtcc.demon.co.uk> wrote:
> Hi All,
>
> A make on a "cvs update" from this morning fails with the following
> error message.
>
> make -C commands all
> make[2]: Entering directory `/usr/local/pgsql/src/backend/commands'
> make[2]: *** No rule to make target `../parse.h', needed by `comment.o'.
>  Stop.
> make[2]: Leaving directory `/usr/local/pgsql/src/backend/commands'
> make[1]: *** [commands.dir] Error 2
> make[1]: Leaving directory `/usr/local/pgsql/src/backend'
> make: *** [install] Error 2
>
> This looks to have been broken by the COMMENT patch.
>
> Keith
>
>
> ************
>


=====

__________________________________________________
Do You Yahoo!?
Bid and sell for free at http://auctions.yahoo.com

Applied.  Thanks.


> Yes.
> 
> This is my fault. Sorry.  Attached is a patch which fixes the problem.
> I missed adding the rule to make parse.h to the Makefile for 
> the ../backend/commands. It also allows for comments to be dropped
> using IS NULL as well as IS '';
> 
> Again, sorry.
> 
> Mike Mascari
> (mascarim@yahoo.com)
> 
> --- Keith Parks <emkxp01@mtcc.demon.co.uk> wrote:
> > Hi All,
> > 
> > A make on a "cvs update" from this morning fails with the following
> > error message.
> > 
> > make -C commands all 
> > make[2]: Entering directory `/usr/local/pgsql/src/backend/commands'
> > make[2]: *** No rule to make target `../parse.h', needed by `comment.o'.
> >  Stop.
> > make[2]: Leaving directory `/usr/local/pgsql/src/backend/commands'
> > make[1]: *** [commands.dir] Error 2
> > make[1]: Leaving directory `/usr/local/pgsql/src/backend'
> > make: *** [install] Error 2
> > 
> > This looks to have been broken by the COMMENT patch.
> > 
> > Keith
> > 
> > 
> > ************
> > 
> 
> 
> =====
> 
> __________________________________________________
> Do You Yahoo!?
> Bid and sell for free at http://auctions.yahoo.com
Content-Description: patchfile

[Attachment, skipping...]


--  Bruce Momjian                        |  http://www.op.net/~candle maillist@candle.pha.pa.us            |  (610)
853-3000+  If your life is a hard drive,     |  830 Blythe Avenue +  Christ can be your backup.        |  Drexel Hill,
Pennsylvania19026
 

> Yes.
> 
> This is my fault. Sorry.  Attached is a patch which fixes the problem.
> I missed adding the rule to make parse.h to the Makefile for 
> the ../backend/commands. It also allows for comments to be dropped
> using IS NULL as well as IS '';
> 

Can we use only NULL, and not '' please?  Seems clearer.  I don't like
us of '' for any special handling.  Thanks.

--  Bruce Momjian                        |  http://www.op.net/~candle maillist@candle.pha.pa.us            |  (610)
853-3000+  If your life is a hard drive,     |  830 Blythe Avenue +  Christ can be your backup.        |  Drexel Hill,
Pennsylvania19026