Thread: pg_dump quoting bug

pg_dump quoting bug

From
"Ross J. Reedstrom"
Date:
One last missing quoting bug in pg_dump:
now that sequence names are properly quoted for field defaults, mixed
case sequence names are generated. These are properly quoted in the
CREATE SEQUENCE lines, but not in the SELECT nextval lines, as per below:

CREATE SEQUENCE "Teams_TeamID_seq" start 10 increment 1 maxvalue
2147483647 minvalue 1  cache 1 ;
SELECT nextval ('Teams_TeamID_seq');

This needs to be:
SELECT nextval ('"Teams_TeamID_seq"');

Patch included below.
--
Ross J. Reedstrom, Ph.D., <reedstrm@rice.edu>
NSBRI Research Scientist/Programmer
Computer and Information Technology Institute
Rice University, 6100 S. Main St.,  Houston, TX 77005

Attachment

Re: [HACKERS] pg_dump quoting bug

From
Bruce Momjian
Date:
Thanks.  Fix applied.  This will appear in 6.6 and the next 6.5.x release.


> One last missing quoting bug in pg_dump:
> now that sequence names are properly quoted for field defaults, mixed
> case sequence names are generated. These are properly quoted in the
> CREATE SEQUENCE lines, but not in the SELECT nextval lines, as per below:
> 
> CREATE SEQUENCE "Teams_TeamID_seq" start 10 increment 1 maxvalue
> 2147483647 minvalue 1  cache 1 ;
> SELECT nextval ('Teams_TeamID_seq');
> 
> This needs to be:
> SELECT nextval ('"Teams_TeamID_seq"');
> 
> Patch included below.
> -- 
> Ross J. Reedstrom, Ph.D., <reedstrm@rice.edu> 
> NSBRI Research Scientist/Programmer
> Computer and Information Technology Institute
> Rice University, 6100 S. Main St.,  Houston, TX 77005

[Attachment, skipping...]


--  Bruce Momjian                        |  http://www.op.net/~candle maillist@candle.pha.pa.us            |  (610)
853-3000+  If your life is a hard drive,     |  830 Blythe Avenue +  Christ can be your backup.        |  Drexel Hill,
Pennsylvania19026