Thread: Re: [HACKERS] misc and triggers regression tests failed on 6. 5be t a1

Re: [HACKERS] misc and triggers regression tests failed on 6. 5be t a1

From
ZEUGSWETTER Andreas IZ5
Date:
>
> > > I have applied a new refint from Massimo.  Can people check that and
> > > make the needed fixes to it and trigger.sql?
> > >
> > Since you seem to want this functionality, could you alter
> > check_primary_key,
> > so that it chooses a default action of  "dependent", and not force us to
> > specify an action ?
>
> I applied it because it was supplied to me.  I have no opinion on way or
> the other.  If you want to reverse this all out, feel free, or add the
> dependent option.
>
I am sorry, I misinterpreted the still failing trigger regression test. The
offending code
has been removed, the action is now always dependent :-)

I suggest the following patch, to finally make trigger regression happy
again:

 <<refint1.patch>>
After that you can remove the following from TODO:
Remove ERROR:  check_primary_key: even number of arguments should be
specified
Trigger regression test fails

Andreas

Attachment

Re: [HACKERS] misc and triggers regression tests failed on 6. 5be t a1

From
Bruce Momjian
Date:
Applied.


> >  
> > > > I have applied a new refint from Massimo.  Can people check that and
> > > > make the needed fixes to it and trigger.sql?
> > > > 
> > > Since you seem to want this functionality, could you alter
> > > check_primary_key, 
> > > so that it chooses a default action of  "dependent", and not force us to
> > > specify an action ?
> > 
> > I applied it because it was supplied to me.  I have no opinion on way or
> > the other.  If you want to reverse this all out, feel free, or add the
> > dependent option.
> > 
> I am sorry, I misinterpreted the still failing trigger regression test. The
> offending code
> has been removed, the action is now always dependent :-)
> 
> I suggest the following patch, to finally make trigger regression happy
> again:
> 
>  <<refint1.patch>> 
> After that you can remove the following from TODO:
> Remove ERROR:  check_primary_key: even number of arguments should be
> specified
> Trigger regression test fails
> 
> Andreas

[Attachment, skipping...]


--  Bruce Momjian                        |  http://www.op.net/~candle maillist@candle.pha.pa.us            |  (610)
853-3000+  If your life is a hard drive,     |  830 Blythe Avenue +  Christ can be your backup.        |  Drexel Hill,
Pennsylvania19026