Thread: latest parser changes

latest parser changes

From
Michael Meskes
Date:
Since FOR UPDATE is not allowed with UNION I suppose it is also not allowed
with INTERSECT and EXCEPT. Is that correct?

Michael
-- 
Michael Meskes                         | Go SF 49ers!
Th.-Heuss-Str. 61, D-41812 Erkelenz    | Go Rhein Fire!
Tel.: (+49) 2431/72651                 | Use Debian GNU/Linux!
Email: Michael.Meskes@gmx.net          | Use PostgreSQL!


Re: [HACKERS] latest parser changes

From
Bruce Momjian
Date:
> Since FOR UPDATE is not allowed with UNION I suppose it is also not allowed
> with INTERSECT and EXCEPT. Is that correct?

Beats me.  I allowed it in the grammer while merging Stephan's stuff
into the code.

--  Bruce Momjian                        |  http://www.op.net/~candle maillist@candle.pha.pa.us            |  (610)
853-3000+  If your life is a hard drive,     |  830 Blythe Avenue +  Christ can be your backup.        |  Drexel Hill,
Pennsylvania19026
 


Re: [HACKERS] latest parser changes

From
Vadim Mikheev
Date:
Michael Meskes wrote:
> 
> Since FOR UPDATE is not allowed with UNION I suppose it is also not allowed
> with INTERSECT and EXCEPT. Is that correct?

Yes. 

Vadim


Re: [HACKERS] latest parser changes

From
Bruce Momjian
Date:
> Michael Meskes wrote:
> > 
> > Since FOR UPDATE is not allowed with UNION I suppose it is also not allowed
> > with INTERSECT and EXCEPT. Is that correct?

Looks like the tests you make in gram.y will still catch those.

--  Bruce Momjian                        |  http://www.op.net/~candle maillist@candle.pha.pa.us            |  (610)
853-3000+  If your life is a hard drive,     |  830 Blythe Avenue +  Christ can be your backup.        |  Drexel Hill,
Pennsylvania19026
 


Re: [HACKERS] latest parser changes

From
Michael Meskes
Date:
On Mon, Jan 18, 1999 at 12:11:38PM -0500, Bruce Momjian wrote:
> > Since FOR UPDATE is not allowed with UNION I suppose it is also not allowed
> > with INTERSECT and EXCEPT. Is that correct?
> 
> Beats me.  I allowed it in the grammer while merging Stephan's stuff
> into the code.

Since I cannot see the appropriate check for this, I guess we should add it
to gram.y.

Michael
-- 
Michael Meskes                         | Go SF 49ers!
Th.-Heuss-Str. 61, D-41812 Erkelenz    | Go Rhein Fire!
Tel.: (+49) 2431/72651                 | Use Debian GNU/Linux!
Email: Michael.Meskes@gmx.net          | Use PostgreSQL!


Re: [HACKERS] latest parser changes

From
Michael Meskes
Date:
On Mon, Jan 18, 1999 at 10:00:14PM -0500, Bruce Momjian wrote:
> > > Since FOR UPDATE is not allowed with UNION I suppose it is also not allowed
> > > with INTERSECT and EXCEPT. Is that correct?
> 
> Looks like the tests you make in gram.y will still catch those.

Where? I just see:

if (n->unionClause != NULL)        elog(ERROR, "SELECT FORUPDATE is not allowed with UNION clause");
                 
 
but not intersect and except. But then I haven't had to time to read the
code carefully.

Michael
-- 
Michael Meskes                         | Go SF 49ers!
Th.-Heuss-Str. 61, D-41812 Erkelenz    | Go Rhein Fire!
Tel.: (+49) 2431/72651                 | Use Debian GNU/Linux!
Email: Michael.Meskes@gmx.net          | Use PostgreSQL!


Re: [HACKERS] latest parser changes

From
Bruce Momjian
Date:
> On Mon, Jan 18, 1999 at 10:00:14PM -0500, Bruce Momjian wrote:
> > > > Since FOR UPDATE is not allowed with UNION I suppose it is also not allowed
> > > > with INTERSECT and EXCEPT. Is that correct?
> > 
> > Looks like the tests you make in gram.y will still catch those.
> 
> Where? I just see:
> 
> if (n->unionClause != NULL)
>          elog(ERROR, "SELECT FORUPDATE is not allowed with UNION clause");
>                                        
> but not intersect and except. But then I haven't had to time to read the
> code carefully.

I thought INTERSECT and EXCEPT used UNION as well, or is that false?  I
don't know.

--  Bruce Momjian                        |  http://www.op.net/~candle maillist@candle.pha.pa.us            |  (610)
853-3000+  If your life is a hard drive,     |  830 Blythe Avenue +  Christ can be your backup.        |  Drexel Hill,
Pennsylvania19026
 


Re: [HACKERS] latest parser changes

From
Michael Meskes
Date:
On Tue, Jan 19, 1999 at 03:47:10PM -0500, Bruce Momjian wrote:
> I thought INTERSECT and EXCEPT used UNION as well, or is that false?  I
> don't know.

I don't think you're right. I see three different rules for the three
keywords.

Michael
-- 
Michael Meskes                         | Go SF 49ers!
Th.-Heuss-Str. 61, D-41812 Erkelenz    | Go Rhein Fire!
Tel.: (+49) 2431/72651                 | Use Debian GNU/Linux!
Email: Michael.Meskes@gmx.net          | Use PostgreSQL!


Re: [HACKERS] latest parser changes

From
Bruce Momjian
Date:
> On Tue, Jan 19, 1999 at 03:47:10PM -0500, Bruce Momjian wrote:
> > I thought INTERSECT and EXCEPT used UNION as well, or is that false?  I
> > don't know.
> 
> I don't think you're right. I see three different rules for the three
> keywords.

I see.  I have added the intersectClause test.

--  Bruce Momjian                        |  http://www.op.net/~candle maillist@candle.pha.pa.us            |  (610)
853-3000+  If your life is a hard drive,     |  830 Blythe Avenue +  Christ can be your backup.        |  Drexel Hill,
Pennsylvania19026