Postgres Pro
Downloads
Home   >   mailing lists

Thread: Re: [HACKERS] CURRENT: crash in select_view regression test...

Re: [HACKERS] CURRENT: crash in select_view regression test...

From
Keith Parks
Date:
Vadim Mikheev <vadim@krs.ru>
> 
> Keith Parks wrote:
> > 
> > Vadim Mikheev <vadim@krs.ru>
> > >
> > > ... in SELECT * FROM street;
> > >
> > 
> > No crash just:-
> > 
> > regression=> select * from street;
> > ERROR:  nodeRead: Bad type 0
> > regression=>
> 
> It seems platform dependent...
> Bugs are in readfuncs.c
> 

I think I've found it, a simple typo in outfuncs.c.

Looks like :vartypmod got transmuted to %vartypmod in an editing session.

Here's the patch,

Keith.

*** src/backend/nodes/outfuncs.c.orig   Thu Dec 17 12:01:02 1998
--- src/backend/nodes/outfuncs.c        Thu Dec 17 12:01:22 1998
***************
*** 634,640 **** _outVar(StringInfo str, Var *node) {       appendStringInfo(str,
!                       " VAR :varno %d :varattno %d :vartype %u %vartypmod %d ",                       node->varno,
                  node->varattno,                       node->vartype,
 
--- 634,640 ---- _outVar(StringInfo str, Var *node) {       appendStringInfo(str,
!                       " VAR :varno %d :varattno %d :vartype %u :vartypmod %d ",                       node->varno,
                  node->varattno,                       node->vartype,

Re: [HACKERS] CURRENT: crash in select_view regression test...

From
The Hermit Hacker
Date:
My fault...patch applied...sorry about that :(


On Thu, 17 Dec 1998, Keith Parks wrote:

> Vadim Mikheev <vadim@krs.ru>
> > 
> > Keith Parks wrote:
> > > 
> > > Vadim Mikheev <vadim@krs.ru>
> > > >
> > > > ... in SELECT * FROM street;
> > > >
> > > 
> > > No crash just:-
> > > 
> > > regression=> select * from street;
> > > ERROR:  nodeRead: Bad type 0
> > > regression=>
> > 
> > It seems platform dependent...
> > Bugs are in readfuncs.c
> > 
> 
> I think I've found it, a simple typo in outfuncs.c.
> 
> Looks like :vartypmod got transmuted to %vartypmod in an editing session.
> 
> Here's the patch,
> 
> Keith.
> 
> *** src/backend/nodes/outfuncs.c.orig   Thu Dec 17 12:01:02 1998
> --- src/backend/nodes/outfuncs.c        Thu Dec 17 12:01:22 1998
> ***************
> *** 634,640 ****
>   _outVar(StringInfo str, Var *node)
>   {
>         appendStringInfo(str,
> !                       " VAR :varno %d :varattno %d :vartype %u %vartypmod %d ",
>                         node->varno,
>                         node->varattno,
>                         node->vartype,
> --- 634,640 ----
>   _outVar(StringInfo str, Var *node)
>   {
>         appendStringInfo(str,
> !                       " VAR :varno %d :varattno %d :vartype %u :vartypmod %d ",
>                         node->varno,
>                         node->varattno,
>                         node->vartype,    
> 
> 

Marc G. Fournier                                
Systems Administrator @ hub.org 
primary: scrappy@hub.org           secondary: scrappy@{freebsd|postgresql}.org