Thread: TCL/TK configuration fixes for PostgreSQL 6.4
The TCL/TK configuration cleanup patches I submitted have the following
problem:
'tclsh' still had to be found even if --with-libs (or --with-libraries) was
specified to configure.
--with-libs is really an overloaded option. It really should only be used
to specify additions directories to search in order to file needed
libraries. It was also being used to locate the *Config.sh files.
This patch addresses these problems by:
1. Creating a new option (--with-tclconfig) which is used to specify the
location of the *Config.sh files. If the tkConfig.sh is located in a
different location than the tclConfig.sh, you can give both locations
seperated by a space. For example:
--with-tclconfig="/opt/lib/tcl8.0 /opt/lib/tk8.0"
2. Changing the search logic so that if '--with-tclconfg' is specified, then
the tcl shell program is not used to obtain a list of directories to search
for the *Config.sh files. It is assumed that the directories given with
the --with-tclconfig option will contain the *Config.sh files.
3. Adding 'tcl' as a name of the tcl shell program to be searched for if
'tclsh' was not found in the PATH. This seems to be another common name
for the tcl shell program.
This patch also moves the clean-up of the generated Makefile.tcldefs and
Makefile.tkdefs in bin/pgtclsh from GNUmakefile.in to the Makefile in
bin/pgtclsh (where, IMHO, they belong).
____ | Billy G. Allie | Domain....: Bill.Allie@mug.org
| /| | 7436 Hartwell | Compuserve: 76337,2061
|-/-|----- | Dearborn, MI 48126| MSN.......: B_G_Allie@email.msn.com
|/ |LLIE | (313) 582-1540 |
Attachment
Applied. > The TCL/TK configuration cleanup patches I submitted have the following > problem: > > 'tclsh' still had to be found even if --with-libs (or --with-libraries) was > specified to configure. > > --with-libs is really an overloaded option. It really should only be used > to specify additions directories to search in order to file needed > libraries. It was also being used to locate the *Config.sh files. > > This patch addresses these problems by: > > 1. Creating a new option (--with-tclconfig) which is used to specify the > location of the *Config.sh files. If the tkConfig.sh is located in a > different location than the tclConfig.sh, you can give both locations > seperated by a space. For example: > > --with-tclconfig="/opt/lib/tcl8.0 /opt/lib/tk8.0" > > 2. Changing the search logic so that if '--with-tclconfg' is specified, then > the tcl shell program is not used to obtain a list of directories to search > for the *Config.sh files. It is assumed that the directories given with > the --with-tclconfig option will contain the *Config.sh files. > > 3. Adding 'tcl' as a name of the tcl shell program to be searched for if > 'tclsh' was not found in the PATH. This seems to be another common name > for the tcl shell program. > > This patch also moves the clean-up of the generated Makefile.tcldefs and > Makefile.tkdefs in bin/pgtclsh from GNUmakefile.in to the Makefile in > bin/pgtclsh (where, IMHO, they belong). Content-Description: uw7-1.patch [Attachment, skipping...] > ____ | Billy G. Allie | Domain....: Bill.Allie@mug.org > | /| | 7436 Hartwell | Compuserve: 76337,2061 > |-/-|----- | Dearborn, MI 48126| MSN.......: B_G_Allie@email.msn.com > |/ |LLIE | (313) 582-1540 | -- Bruce Momjian | http://www.op.net/~candle maillist@candle.pha.pa.us | (610) 853-3000 + If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania 19026
Applied. > The TCL/TK configuration cleanup patches I submitted have the following > problem: > > 'tclsh' still had to be found even if --with-libs (or --with-libraries) was > specified to configure. > > --with-libs is really an overloaded option. It really should only be used > to specify additions directories to search in order to file needed > libraries. It was also being used to locate the *Config.sh files. > > This patch addresses these problems by: > > 1. Creating a new option (--with-tclconfig) which is used to specify the > location of the *Config.sh files. If the tkConfig.sh is located in a > different location than the tclConfig.sh, you can give both locations > seperated by a space. For example: > > --with-tclconfig="/opt/lib/tcl8.0 /opt/lib/tk8.0" > > 2. Changing the search logic so that if '--with-tclconfg' is specified, then > the tcl shell program is not used to obtain a list of directories to search > for the *Config.sh files. It is assumed that the directories given with > the --with-tclconfig option will contain the *Config.sh files. > > 3. Adding 'tcl' as a name of the tcl shell program to be searched for if > 'tclsh' was not found in the PATH. This seems to be another common name > for the tcl shell program. > > This patch also moves the clean-up of the generated Makefile.tcldefs and > Makefile.tkdefs in bin/pgtclsh from GNUmakefile.in to the Makefile in > bin/pgtclsh (where, IMHO, they belong). Content-Description: uw7-1.patch [Attachment, skipping...] > ____ | Billy G. Allie | Domain....: Bill.Allie@mug.org > | /| | 7436 Hartwell | Compuserve: 76337,2061 > |-/-|----- | Dearborn, MI 48126| MSN.......: B_G_Allie@email.msn.com > |/ |LLIE | (313) 582-1540 | -- Bruce Momjian | http://www.op.net/~candle maillist@candle.pha.pa.us | (610) 853-3000 + If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania 19026