Thread: minor problem with detecting int64 in configure

I have found a minor problem with current configure.in.

[AC_MSG_RESULT(yes) AC_DEFINE(HAVE_LONG_INT_64)],

this line produces something like:

  echo "$ac_t""yes" 1>&6 cat >> confdefs.h <<\EOF

and would append garbage "yes cat" to confdefs.h. Of course the result
confdefs.h is not syntactically correct therefore following tests
using confdefs.h would all fail.
To avoid the problem, we could switch the order of AC_MSG_RESULT and
AC_DEFINE (see attached patch). This happend on my LinuxPPC box.
--
Tatsuo Ishii
t-ishii@sra.co.jp
-------------------------------------------------------------------
*** configure.in.orig    Mon Aug 24 12:34:26 1998
--- configure.in    Mon Aug 24 12:31:50 1998
***************
*** 596,602 ****
  main() {
    exit(! does_int64_work());
  }],
!     [AC_MSG_RESULT(yes) AC_DEFINE(HAVE_LONG_LONG_INT_64)],
      AC_MSG_RESULT(no),
      AC_MSG_RESULT(assuming not on target machine))

--- 596,602 ----
  main() {
    exit(! does_int64_work());
  }],
!     [AC_DEFINE(HAVE_LONG_LONG_INT_64) AC_MSG_RESULT(yes)],
      AC_MSG_RESULT(no),
      AC_MSG_RESULT(assuming not on target machine))

t-ishii@sra.co.jp writes:
> I have found a minor problem with current configure.in.
> [AC_MSG_RESULT(yes) AC_DEFINE(HAVE_LONG_INT_64)],
> this line produces something like:
>   echo "$ac_t""yes" 1>&6 cat >> confdefs.h <<\EOF
> and would append garbage "yes cat" to confdefs.h.

Oops.  My bad.  Patcher please note that the HAVE_LONG_LONG_INT_64
test needs the same fix.

            regards, tom lane

> t-ishii@sra.co.jp writes:
> > I have found a minor problem with current configure.in.
> > [AC_MSG_RESULT(yes) AC_DEFINE(HAVE_LONG_INT_64)],
> > this line produces something like:
> >   echo "$ac_t""yes" 1>&6 cat >> confdefs.h <<\EOF
> > and would append garbage "yes cat" to confdefs.h.
>
> Oops.  My bad.  Patcher please note that the HAVE_LONG_LONG_INT_64
> test needs the same fix.

Done.  Autoconf done.

--
Bruce Momjian                          |  830 Blythe Avenue
maillist@candle.pha.pa.us              |  Drexel Hill, Pennsylvania 19026
  +  If your life is a hard drive,     |  (610) 353-9879(w)
  +  Christ can be your backup.        |  (610) 853-3000(h)