Thread: Massive patch

Massive patch

From
Bruce Momjian
Date:
OK, here are the details to the patch I am currently applying.  It
cleans up a lot of the internal tuple access routines.

cvs update and initdb, everyone.

---------------------------------------------------------------------------


heap_fetch requires buffer pointer, must be released
heap_getnext no longer returns buffer pointer, can be gotten from scan
    descriptor
bootstrap can create multi-key indexes
pg_procname index now is multi-key index
oidint2, oidint4, oidname are gone (must be removed from regression tests)
use System Cache rather than sequential scan in many places
heap_modifytuple no longer takes buffer parameter
remove unused buffer parameter in a few other functions
oid8 is not index-able
remove some use of single-character variable names
cleanup Buffer variables usage and scan descriptor looping
cleaned up allocation and freeing of tuples
18k lines of diff

--
Bruce Momjian                          |  830 Blythe Avenue
maillist@candle.pha.pa.us              |  Drexel Hill, Pennsylvania 19026
  +  If your life is a hard drive,     |  (610) 353-9879(w)
  +  Christ can be your backup.        |  (610) 853-3000(h)

Re: [HACKERS] Massive patch

From
Bruce Momjian
Date:
> OK, here are the details to the patch I am currently applying.  It
> cleans up a lot of the internal tuple access routines.
>
> cvs update and initdb, everyone.
>
> ---------------------------------------------------------------------------
>
>
> heap_fetch requires buffer pointer, must be released
> heap_getnext no longer returns buffer pointer, can be gotten from scan
>     descriptor
> bootstrap can create multi-key indexes
> pg_procname index now is multi-key index
> oidint2, oidint4, oidname are gone (must be removed from regression tests)
> use System Cache rather than sequential scan in many places
> heap_modifytuple no longer takes buffer parameter
> remove unused buffer parameter in a few other functions
> oid8 is not index-able
          ^^^

I meant to say "now indexable".

> remove some use of single-character variable names
> cleanup Buffer variables usage and scan descriptor looping
> cleaned up allocation and freeing of tuples
> 18k lines of diff
>
> --
> Bruce Momjian                          |  830 Blythe Avenue
> maillist@candle.pha.pa.us              |  Drexel Hill, Pennsylvania 19026
>   +  If your life is a hard drive,     |  (610) 353-9879(w)
>   +  Christ can be your backup.        |  (610) 853-3000(h)
>
>


--
Bruce Momjian                          |  830 Blythe Avenue
maillist@candle.pha.pa.us              |  Drexel Hill, Pennsylvania 19026
  +  If your life is a hard drive,     |  (610) 353-9879(w)
  +  Christ can be your backup.        |  (610) 853-3000(h)