Postgres Pro
Downloads
Home   >   mailing lists

Thread: pglesslog for Postgres 9.1.1

pglesslog for Postgres 9.1.1

From
"mailtolouis2020-postgres@yahoo.com"
Date:
Hi,

Is anyone able to compile pglesslog under postgres9.1.1 ?
When I try it I got this error:

make -f Makefile.pg_compresslog all
make[1]: Entering directory `/usr/src/postgresql-9.1.1/contrib/pg_lesslog_1.4.2_pg90'
gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wformat-security -fno-strict-aliasing -fwrapv -I. -I. -I../../src/include -D_GNU_SOURCE   -c -o remove.o remove.c
remove.c: In function ‘remove_bkp_block’:
remove.c:182: error: ‘XLOG_GIN_INSERT’ undeclared (first use in this function)
remove.c:182: error: (Each undeclared identifier is reported only once
remove.c:182: error: for each function it appears in.)
remove.c:184: error: ‘XLOG_GIN_VACUUM_PAGE’ undeclared (first use in this function)
remove.c:186: error: ‘XLOG_GIN_DELETE_PAGE’ undeclared (first use in this function)
make[1]: *** [remove.o] Error 1
make[1]: Leaving directory `/usr/src/postgresql-9.1.1/contrib/pg_lesslog_1.4.2_pg90'
make: *** [all] Error 2


Regards
Louis

Re: pglesslog for Postgres 9.1.1

From
Tom Lane
Date:
"mailtolouis2020-postgres@yahoo.com" <mailtolouis2020-postgres@yahoo.com> writes:
> remove.c:182: error: ‘XLOG_GIN_INSERT’ undeclared (first use in this function)
> remove.c:182: error: (Each undeclared identifier is reported only once
> remove.c:182: error: for each function it appears in.)
> remove.c:184: error: ‘XLOG_GIN_VACUUM_PAGE’ undeclared (first use in this function)
> remove.c:186: error: ‘XLOG_GIN_DELETE_PAGE’ undeclared (first use in this function)

That stuff got moved to gin_private.h in 9.1 ...

            regards, tom lane

Re: pglesslog for Postgres 9.1.1

From
"mailtolouis2020-postgres@yahoo.com"
Date:
Hi,

I'm sorry I'm not good in C, anyone can help to put a patch or release a new version for that?



Regards
Louis
From: Tom Lane <tgl@sss.pgh.pa.us>
To: "mailtolouis2020-postgres@yahoo.com" <mailtolouis2020-postgres@yahoo.com>
Cc: Postgres <pgsql-general@postgresql.org>
Sent: Wednesday, October 26, 2011 3:42 PM
Subject: Re: [GENERAL] pglesslog for Postgres 9.1.1

"mailtolouis2020-postgres@yahoo.com" <mailtolouis2020-postgres@yahoo.com> writes:
> remove.c:182: error: ‘XLOG_GIN_INSERT’ undeclared (first use in this function)
> remove.c:182: error: (Each undeclared identifier is reported only once
> remove.c:182: error: for each function it appears in.)
> remove.c:184: error: ‘XLOG_GIN_VACUUM_PAGE’ undeclared (first use in this function)
> remove.c:186: error: ‘XLOG_GIN_DELETE_PAGE’ undeclared (first use in this function)

That stuff got moved to gin_private.h in 9.1 ...

            regards, tom lane


Re: pglesslog for Postgres 9.1.1

From
Satoshi Nagayasu
Date:
Hi Louis,

2011/10/27 19:49, mailtolouis2020-postgres@yahoo.com wrote:
> Hi,
>
> I'm sorry I'm not good in C, anyone can help to put a patch or release a new version for that?
>
>
>
> Regards
> Louis
>
>
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
-------
>     *From:* Tom Lane <tgl@sss.pgh.pa.us>
>     *To:* "mailtolouis2020-postgres@yahoo.com" <mailtolouis2020-postgres@yahoo.com>
>     *Cc:* Postgres <pgsql-general@postgresql.org>
>     *Sent:* Wednesday, October 26, 2011 3:42 PM
>     *Subject:* Re: [GENERAL] pglesslog for Postgres 9.1.1
>
>     "mailtolouis2020-postgres@yahoo.com <mailto:mailtolouis2020-postgres@yahoo.com>"
<mailtolouis2020-postgres@yahoo.com<mailto:mailtolouis2020-postgres@yahoo.com>> writes: 
>      > remove.c:182: error: ‘XLOG_GIN_INSERT’ undeclared (first use in this function)
>      > remove.c:182: error: (Each undeclared identifier is reported only once
>      > remove.c:182: error: for each function it appears in.)
>      > remove.c:184: error: ‘XLOG_GIN_VACUUM_PAGE’ undeclared (first use in this function)
>      > remove.c:186: error: ‘XLOG_GIN_DELETE_PAGE’ undeclared (first use in this function)
>
>     That stuff got moved to gin_private.h in 9.1 ...
>
>     regards, tom lane

I'm taking part in.

Try this patch,

https://gist.github.com/1321650

and build as following.

$ make USE_PGXS=1 top_builddir=/path/to/postgresql-9.1.0

Regards,

--
NAGAYASU Satoshi <satoshi.nagayasu@gmail.com>

Re: pglesslog for Postgres 9.1.1

From
"mailtolouis2020-postgres@yahoo.com"
Date:
Hi,

Thanks for the patch, tested and it working fine.

Regards
Louis

From: Satoshi Nagayasu <satoshi.nagayasu@gmail.com>
To: "mailtolouis2020-postgres@yahoo.com" <mailtolouis2020-postgres@yahoo.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>; Postgres <pgsql-general@postgresql.org>
Sent: Friday, October 28, 2011 5:51 AM
Subject: Re: [GENERAL] pglesslog for Postgres 9.1.1

Hi Louis,

2011/10/27 19:49, mailtolouis2020-postgres@yahoo.com wrote:
> Hi,
>
> I'm sorry I'm not good in C, anyone can help to put a patch or release a new version for that?
>
>
>
> Regards
> Louis
>
>    ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ -----------------
-------
>    *From:* Tom Lane <tgl@sss.pgh.pa.us>
>    *To:* "mailtolouis2020-postgres@yahoo.com" <mailtolouis2020-postgres@yahoo.com>
>    *Cc:* Postgres <pgsql-general@postgresql.org>
>    *Sent:* Wednesday, October 26, 2011 3:42 PM
>    *Subject:* Re: [GENERAL] pglesslog for Postgres 9.1.1
>
>    "mailtolouis2020-postgres@yahoo.com <mailto:mailtolouis2020-postgres@yahoo.com>" <mailtolouis2020-postgres@yahoo.com <mailto:mailtolouis2020-postgres@yahoo.com>> writes:
>      > remove.c:182: error: ‘XLOG_GIN_INSERT’ undeclared (first use in this function)
>      > remove.c:182: error: (Each undeclared identifier is reported only once
>      > remove.c:182: error: for each function it appears in.)
>      > remove.c:184: error: ‘XLOG_GIN_VACUUM_PAGE’ undeclared (first use in this function)
>      > remove.c:186: error: ‘XLOG_GIN_DELETE_PAGE’ undeclared (first use in this function)
>
>    That stuff got moved to gin_private.h in 9.1 ...
>
>    regards, tom lane

I'm taking part in.

Try this patch,

https://gist.github.com/1321650

and build as following.

$ make USE_PGXS=1 top_builddir=/path/to/postgresql-9.1.0

Regards,

--
NAGAYASU Satoshi <satoshi.nagayasu@gmail.com>