Thread: Problems with pg_dump ?

Hello,

I found small problem and doesn't know where to dig.
Ok let's start.

postgresql 8.2.7
OS - linux

Create table and view.

CREATE TABLE t1 (
    a integer NOT NULL,
    b integer NOT NULL
);

CREATE OR REPLACE VIEW v1 AS SELECT DISTINCT a,b, -1 AS d, -1 AS e FROM t1;

After this i dump database with pg_dump and have following output.

--- pg_dump output start ---
--
-- Name: t1; Type: TABLE; Schema: public; Owner: postgres; Tablespace:
--
CREATE TABLE t1 (
    a integer NOT NULL,  b integer NOT NULL
);
ALTER TABLE public.t1 OWNER TO postgres;

--
-- Name: v1; Type: VIEW; Schema: public; Owner: postgres
--
CREATE VIEW v1 AS
    SELECT DISTINCT t1.a, t1.b, -1 AS d, -1 AS e FROM t1 ORDER BY t1.a, t1.b, -1::integer, -1::integer;
ALTER TABLE public.v1 OWNER TO postgres;
--- pg_dump output end ---

And when i try to restore this thing on new DB i get following error while creating view

ERROR:  for SELECT DISTINCT, ORDER BY expressions must appear in select list

Any help will be appreciated

--

Alexandr Popov

Alexandr Popov <alexandr.popov@nexui.md> writes:
> CREATE OR REPLACE VIEW v1 AS SELECT DISTINCT a,b, -1 AS d, -1 AS e FROM t1;

> After this i dump database with pg_dump and have following output.

> CREATE VIEW v1 AS
>     SELECT DISTINCT t1.a, t1.b, -1 AS d, -1 AS e FROM t1 ORDER BY t1.a, t1.b, -1::integer, -1::integer;

Sigh ... this is a bug in my patch of a few months ago:
http://archives.postgresql.org/pgsql-committers/2008-01/msg00081.php
It needs to be parenthesizing those constants, because as-is the ::
binds more tightly than the -, and "-(1::integer)" is a run-time
negation, not a simple constant.

            regards, tom lane