Thread: Making pg_dump cvs friendly

Making pg_dump cvs friendly

From
Jonathan Bartlett
Date:
I have created a patch to postgresql 7.3.3 to make pg_dump more CVS
friendly.  Basically, pg_dump numbers all of it's TOC entries.  Therefore,
if you modify or recreate a view that used to be at the beginning, then
ALL of your tables/indexes/etc get renumbered, which causes a lot of junk
in your CVS.

Anyway, the patch is at

http://www.eskimo.com/~johnnyb/pgdump-cvs-patch.diff

Comments welcome, but this is my first patch, so please be gentle :)

Jon


Re: Making pg_dump cvs friendly

From
Bruce Momjian
Date:
Your patch has been added to the PostgreSQL unapplied patches list at:

    http://momjian.postgresql.org/cgi-bin/pgpatches

I will try to apply it within the next 48 hours.

I will merge the two options into one and update the docs accordingly.

---------------------------------------------------------------------------


Jonathan Bartlett wrote:
> I have created a patch to postgresql 7.3.3 to make pg_dump more CVS
> friendly.  Basically, pg_dump numbers all of it's TOC entries.  Therefore,
> if you modify or recreate a view that used to be at the beginning, then
> ALL of your tables/indexes/etc get renumbered, which causes a lot of junk
> in your CVS.
>
> Anyway, the patch is at
>
> http://www.eskimo.com/~johnnyb/pgdump-cvs-patch.diff
>
> Comments welcome, but this is my first patch, so please be gentle :)
>
> Jon
>
>
> ---------------------------(end of broadcast)---------------------------
> TIP 1: subscribe and unsubscribe commands go to majordomo@postgresql.org
>

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

Re: Making pg_dump cvs friendly

From
Peter Eisentraut
Date:
Bruce Momjian writes:

> Your patch has been added to the PostgreSQL unapplied patches list at:
>
>     http://momjian.postgresql.org/cgi-bin/pgpatches
>
> I will try to apply it within the next 48 hours.
>
> I will merge the two options into one and update the docs accordingly.

I don't think we need to the short option.  -m doesn't make sense.  The
documentation belongs in the pg_dump reference page, not backup.sgml.  The
help text of the option should be adjusted to look more like the adjacent
texts.  References to CVS don't belong into the --help output.

--
Peter Eisentraut   peter_e@gmx.net


Re: Making pg_dump cvs friendly

From
Bruce Momjian
Date:
Peter Eisentraut wrote:
> Bruce Momjian writes:
>
> > Your patch has been added to the PostgreSQL unapplied patches list at:
> >
> >     http://momjian.postgresql.org/cgi-bin/pgpatches
> >
> > I will try to apply it within the next 48 hours.
> >
> > I will merge the two options into one and update the docs accordingly.
>
> I don't think we need to the short option.  -m doesn't make sense.  The

Do we actually have flags that can only be specified by long ars?  If
so, I don't see any in pg_dump or psql.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

Re: Making pg_dump cvs friendly

From
Bruce Momjian
Date:
Jonathan Bartlett wrote:
> I have created a patch to postgresql 7.3.3 to make pg_dump more CVS
> friendly.  Basically, pg_dump numbers all of it's TOC entries.  Therefore,
> if you modify or recreate a view that used to be at the beginning, then
> ALL of your tables/indexes/etc get renumbered, which causes a lot of junk
> in your CVS.
>
> Anyway, the patch is at
>
> http://www.eskimo.com/~johnnyb/pgdump-cvs-patch.diff
>
> Comments welcome, but this is my first patch, so please be gentle :)

7.5 will no longer output TOC numbers or oids unless you specify
--verbose in the dump, so these new pg_dump options are no longer
required.  Thanks.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073