Thread: Small bug in postgres' ./configure script and invalid bug-report-link on website
Small bug in postgres' ./configure script and invalid bug-report-link on website
From
Arjen van der Meijden
Date:
Hi List, I'm using flex 2.5.31 acm@server pgsql $ flex --version flex 2.5.31 And get this warning from the configure-script (in latest cvs): checking for flex... no configure: WARNING: *** The Flex version 2.5.3 you have at /usr/bin/lex contains a bug. You *** should get version 2.5.4 or later. configure: WARNING: *** Without Flex you will not be able to build PostgreSQL from CVS or *** change any of the scanner definition files. You can obtain Flex from *** a GNU mirror site. (If you are using the official distribution of *** PostgreSQL then you do not need to worry about this because the Flex *** output is pre-generated.) Of course the regexp on line 3580 of the configure-script is wrong: if $pgac_candidate --version | grep '2\.5\.3' >/dev/null 2>&1; then I don't know a real solution, probably something like changing the grep to read: grep -e `2\.5\.3$' Or adding a second grep to grep out 2\.5\.3[0-9] Ow and the reason why I didn't try reporting this via the "Report a bug" link on the postgresql-website is because that gave me a 404-error. "Not Found The requested URL /bugs/bugs.php was not found on this server. Apache/1.3.27 Server at www.ca.postgresql.org Port 80" Regards, Arjen
Thanks. Patch attached. This will be in 7.4. --------------------------------------------------------------------------- Arjen van der Meijden wrote: > Hi List, > > I'm using flex 2.5.31 > > acm@server pgsql $ flex --version > flex 2.5.31 > > And get this warning from the configure-script (in latest cvs): > > checking for flex... no > configure: WARNING: > *** The Flex version 2.5.3 you have at /usr/bin/lex contains a bug. You > *** should get version 2.5.4 or later. > configure: WARNING: > *** Without Flex you will not be able to build PostgreSQL from CVS or > *** change any of the scanner definition files. You can obtain Flex > from > *** a GNU mirror site. (If you are using the official distribution of > *** PostgreSQL then you do not need to worry about this because the Flex > *** output is pre-generated.) > > Of course the regexp on line 3580 of the configure-script is wrong: > if $pgac_candidate --version | grep '2\.5\.3' >/dev/null 2>&1; then > > I don't know a real solution, probably something like changing the grep > to read: > grep -e `2\.5\.3$' > Or adding a second grep to grep out 2\.5\.3[0-9] > > Ow and the reason why I didn't try reporting this via the "Report a bug" > link on the postgresql-website is because that gave me a 404-error. > "Not Found > The requested URL /bugs/bugs.php was not found on this server. > > Apache/1.3.27 Server at www.ca.postgresql.org Port 80" > > Regards, > > Arjen > > > ---------------------------(end of broadcast)--------------------------- > TIP 4: Don't 'kill -9' the postmaster > -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania 19073 Index: configure =================================================================== RCS file: /cvsroot/pgsql-server/configure,v retrieving revision 1.252 diff -c -c -r1.252 configure *** configure 24 Apr 2003 21:16:42 -0000 1.252 --- configure 6 May 2003 23:25:51 -0000 *************** *** 3577,3583 **** then echo '%%' > conftest.l if $pgac_candidate -t conftest.l 2>/dev/null | grep FLEX_SCANNER >/dev/null 2>&1; then ! if $pgac_candidate --version | grep '2\.5\.3' >/dev/null 2>&1; then pgac_broken_flex=$pgac_candidate continue fi --- 3577,3583 ---- then echo '%%' > conftest.l if $pgac_candidate -t conftest.l 2>/dev/null | grep FLEX_SCANNER >/dev/null 2>&1; then ! if $pgac_candidate --version | grep '2\.5\.3$' >/dev/null 2>&1; then pgac_broken_flex=$pgac_candidate continue fi Index: config/programs.m4 =================================================================== RCS file: /cvsroot/pgsql-server/config/programs.m4,v retrieving revision 1.11 diff -c -c -r1.11 programs.m4 *** config/programs.m4 6 Apr 2003 22:45:22 -0000 1.11 --- config/programs.m4 6 May 2003 23:25:51 -0000 *************** *** 26,32 **** then echo '%%' > conftest.l if $pgac_candidate -t conftest.l 2>/dev/null | grep FLEX_SCANNER >/dev/null 2>&1; then ! if $pgac_candidate --version | grep '2\.5\.3' >/dev/null 2>&1; then pgac_broken_flex=$pgac_candidate continue fi --- 26,32 ---- then echo '%%' > conftest.l if $pgac_candidate -t conftest.l 2>/dev/null | grep FLEX_SCANNER >/dev/null 2>&1; then ! if $pgac_candidate --version | grep ' 2\.5\.3$' >/dev/null 2>&1; then pgac_broken_flex=$pgac_candidate continue fi
Bruce Momjian <pgman@candle.pha.pa.us> writes:
> Thanks. Patch attached. This will be in 7.4.
Please backpatch into 7.3 branch too.
(How the heck did flex get to a .31 minor release?)
regards, tom lane
Tom Lane wrote: > Bruce Momjian <pgman@candle.pha.pa.us> writes: > > Thanks. Patch attached. This will be in 7.4. > > Please backpatch into 7.3 branch too. > > (How the heck did flex get to a .31 minor release?) Good idea. Done. -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania 19073
On Wed, 2003-05-07 at 05:49, Bruce Momjian wrote: > Tom Lane wrote: > > Bruce Momjian <pgman@candle.pha.pa.us> writes: > > > Thanks. Patch attached. This will be in 7.4. > > > > Please backpatch into 7.3 branch too. > > > > (How the heck did flex get to a .31 minor release?) > > Good idea. Done. But remember that flex 2.5.31 breaks the existing lexer code. In spite of being only a minor release, its code requirements are not completely compatible with 2.5.4a. -- Oliver Elphick Oliver.Elphick@lfix.co.uk Isle of Wight, UK http://www.lfix.co.uk/oliver GPG: 1024D/3E1D0C1C: CA12 09E0 E8D5 8870 5839 932A 614D 4C34 3E1D 0C1C ======================================== "Dearly beloved, avenge not yourselves, but rather give place unto wrath. For it is written, Vengeance is mine; I will repay, saith the Lord. Therefore if thine enemy hunger, feed him; if he thirst, give him drink; for in so doing thou shalt heap coals of fire on his head. Be not overcome of evil, but overcome evil with good." Romans 12:19-21
Yes I already downgraded back to 2.5.4a, I thought some compilation issues with postgres' devel version were caused by an out-of-date flex. But they were all due to an out-of-date bison (version 1.75 and later on 1.875 made it compile, while 1.35 failed). Although it is still a bug in de configure-script ;) Arjen > -----Oorspronkelijk bericht----- > Van: Oliver Elphick [mailto:olly@lfix.co.uk] > Verzonden: woensdag 7 mei 2003 7:41 > Aan: Bruce Momjian > CC: Tom Lane; Arjen van der Meijden; pgsql-general@postgresql.org > Onderwerp: Re: [GENERAL] Small bug in postgres' ./configure > script and invalid > > > On Wed, 2003-05-07 at 05:49, Bruce Momjian wrote: > > Tom Lane wrote: > > > Bruce Momjian <pgman@candle.pha.pa.us> writes: > > > > Thanks. Patch attached. This will be in 7.4. > > > > > > Please backpatch into 7.3 branch too. > > > > > > (How the heck did flex get to a .31 minor release?) > > > > Good idea. Done. > > But remember that flex 2.5.31 breaks the existing lexer code. > In spite of being only a minor release, its code > requirements are not completely compatible with 2.5.4a. > > -- > Oliver Elphick > Oliver.Elphick@lfix.co.uk > Isle of Wight, UK > http://www.lfix.co.uk/oliver > GPG: 1024D/3E1D0C1C: CA12 09E0 > E8D5 8870 5839 932A 614D 4C34 3E1D 0C1C > ======================================== > "Dearly beloved, avenge not yourselves, but rather give > place unto wrath. For it is written, Vengeance is > mine; I will repay, saith the Lord. Therefore if thine > enemy hunger, feed him; if he thirst, give him drink; > for in so doing thou shalt heap coals of fire on his > head. Be not overcome of evil, but overcome evil with > good." Romans 12:19-21 > >
On Wed, 2003-05-07 at 00:41, Oliver Elphick wrote: > On Wed, 2003-05-07 at 05:49, Bruce Momjian wrote: > > Tom Lane wrote: > > > Bruce Momjian <pgman@candle.pha.pa.us> writes: > > > > Thanks. Patch attached. This will be in 7.4. > > > > > > Please backpatch into 7.3 branch too. > > > > > > (How the heck did flex get to a .31 minor release?) > > > > Good idea. Done. > > But remember that flex 2.5.31 breaks the existing lexer code. In spite > of being only a minor release, its code requirements are not completely > compatible with 2.5.4a. From your reply, I must ask: does 2.5.31 come after 2.5.30, or does it tweak 2.5.3? -- +---------------------------------------------------------------+ | Ron Johnson, Jr. mailto:ron.l.johnson@cox.net | | Jefferson, LA USA http://members.cox.net/ron.l.johnson | | | | The purpose of the military isn't to pay your college tuition | | or give you a little extra income; it's to "kill people and | | break things". Surprisingly, not everyone understands that. | +---------------------------------------------------------------+
http://sourceforge.net/project/showfiles.php?group_id=72099 If they present it as the latest and the previous was .27, I suppose it really is .31 and not .3something :) Arjen > -----Oorspronkelijk bericht----- > Van: pgsql-general-owner@postgresql.org > [mailto:pgsql-general-owner@postgresql.org] Namens Ron Johnson > Verzonden: woensdag 7 mei 2003 13:46 > Aan: pgsql-general@postgresql.org > Onderwerp: Re: [GENERAL] Small bug in postgres' ./configure > script and invalid > > > On Wed, 2003-05-07 at 00:41, Oliver Elphick wrote: > > On Wed, 2003-05-07 at 05:49, Bruce Momjian wrote: > > > Tom Lane wrote: > > > > Bruce Momjian <pgman@candle.pha.pa.us> writes: > > > > > Thanks. Patch attached. This will be in 7.4. > > > > > > > > Please backpatch into 7.3 branch too. > > > > > > > > (How the heck did flex get to a .31 minor release?) > > > > > > Good idea. Done. > > > > But remember that flex 2.5.31 breaks the existing lexer code. In > > spite of being only a minor release, its code requirements are not > > completely compatible with 2.5.4a. > > From your reply, I must ask: does 2.5.31 come after 2.5.30, > or does it tweak 2.5.3? > > -- > +---------------------------------------------------------------+ > | Ron Johnson, Jr. mailto:ron.l.johnson@cox.net | > | Jefferson, LA USA http://members.cox.net/ron.l.johnson | > | | The > | purpose of the military isn't to pay your college tuition | > | or give you a little extra income; it's to "kill people and | > | break things". Surprisingly, not everyone understands that. | > +---------------------------------------------------------------+ > > > ---------------------------(end of > broadcast)--------------------------- > TIP 2: you can get off all lists at once with the unregister command > (send "unregister YourEmailAddressHere" to > majordomo@postgresql.org) > >
On Wed, 2003-05-07 at 12:45, Ron Johnson wrote: > On Wed, 2003-05-07 at 00:41, Oliver Elphick wrote: > > But remember that flex 2.5.31 breaks the existing lexer code. In spite > > of being only a minor release, its code requirements are not completely > > compatible with 2.5.4a. > > >From your reply, I must ask: does 2.5.31 come after 2.5.30, or does > it tweak 2.5.3? The former. I don't know exactly what has been going on, but I think: 2.5.3 is an old buggy flex 2.5.4a has been the standard for a while 2.5.30 was recently released to the world as the next flex and 2.5.31 seems to be some fixes and enhancements on that -- Oliver Elphick Oliver.Elphick@lfix.co.uk Isle of Wight, UK http://www.lfix.co.uk/oliver GPG: 1024D/3E1D0C1C: CA12 09E0 E8D5 8870 5839 932A 614D 4C34 3E1D 0C1C ======================================== "Dearly beloved, avenge not yourselves, but rather give place unto wrath. For it is written, Vengeance is mine; I will repay, saith the Lord. Therefore if thine enemy hunger, feed him; if he thirst, give him drink; for in so doing thou shalt heap coals of fire on his head. Be not overcome of evil, but overcome evil with good." Romans 12:19-21