Postgres Pro
Downloads
Home   >   mailing lists

Thread: plpgsql commenting broken?

plpgsql commenting broken?

From
"Johnny Jørgensen"
Date:
After quite a few hours of poring over my latest plpgsql dabbling,  i found the error that caused import to barf, and I was a bit surprised, since the error was caused by a single apostrophe in a comment line
 
-- check if the row isn't available
[SQL thingie]
 
of course, i could avoid the problem by rewriting my comments to
 
-- check if the row is available
[SQL thingie]
 
but it seems to me, that commenting a line should cause the parser to ignore *everything* until the next newline?
 
regards,

Johnny J�rgensen
 
+45 6315 7328

Re: plpgsql commenting broken?

From
Bruce Momjian
Date:
> After quite a few hours of poring over my latest plpgsql dabbling,  i found the error that caused import to barf, and
Iwas a bit surprised, since the error was caused by a single apostrophe in a comment line 
>
> -- check if the row isn't available
> [SQL thingie]
>
> of course, i could avoid the problem by rewriting my comments to
>
> -- check if the row is available
> [SQL thingie]
>
> but it seems to me, that commenting a line should cause the parser to ignore *everything* until the next newline?

Yes, this has bitten me before, particularly in awk script where the
script is single-quoted.  I don't know a good solution for this.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026