Thread: Re: [PATCHES] small doc patch for regexp_replace

Re: [PATCHES] small doc patch for regexp_replace

From
Bruce Momjian
Date:
Tom Lane wrote:
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > Seems there is some inconsistency there.  There are two types of
> > function listings, one with just the types, and another with param_name
> > and then type.  We use "string" instead of "text" because varchar() and
> > char() can also be used.

There are many mentions of <parameter>string</> used a function
arguments in func.sgml.  Should those be changed to <type>text</>?

--
  Bruce Momjian   http://candle.pha.pa.us
  EnterpriseDB    http://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

Re: [PATCHES] small doc patch for regexp_replace

From
Tom Lane
Date:
Bruce Momjian <pgman@candle.pha.pa.us> writes:
> There are many mentions of <parameter>string</> used a function
> arguments in func.sgml.  Should those be changed to <type>text</>?

<parameter>string</> is fine, especially if the function actually has a
separate variant for bpchar.  I was just unhappy with <type>string</>,
which is a lie.

            regards, tom lane

Re: [PATCHES] small doc patch for regexp_replace

From
Bruce Momjian
Date:
Tom Lane wrote:
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > There are many mentions of <parameter>string</> used a function
> > arguments in func.sgml.  Should those be changed to <type>text</>?
>
> <parameter>string</> is fine, especially if the function actually has a
> separate variant for bpchar.  I was just unhappy with <type>string</>,

FYI, in most cases, they don't have bpchar variants.

--
  Bruce Momjian   http://candle.pha.pa.us
  EnterpriseDB    http://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +