Thread: plperl doc update

plperl doc update

From
Bruce Momjian
Date:
I have applied the following doc update for plperl, now that perl has an
--enable-shared configure option.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073
Index: installation.sgml
===================================================================
RCS file: /cvsroot/pgsql-server/doc/src/sgml/installation.sgml,v
retrieving revision 1.194
retrieving revision 1.195
diff -c -c -r1.194 -r1.195
*** installation.sgml    3 Feb 2004 17:34:02 -0000    1.194
--- installation.sgml    26 Feb 2004 02:09:40 -0000    1.195
***************
*** 1,4 ****
! <!-- $PostgreSQL: pgsql-server/doc/src/sgml/installation.sgml,v 1.194 2004/02/03 17:34:02 tgl Exp $ -->

  <chapter id="installation">
   <title><![%standalone-include[<productname>PostgreSQL</>]]>
--- 1,4 ----
! <!-- $PostgreSQL: pgsql-server/doc/src/sgml/installation.sgml,v 1.195 2004/02/26 02:09:40 momjian Exp $ -->

  <chapter id="installation">
   <title><![%standalone-include[<productname>PostgreSQL</>]]>
***************
*** 193,206 ****
       </para>

       <para>
!       The catch is that the Python distribution or the Python
!       maintainers do not provide any direct way to do this.  The
!       closest thing we can offer you is the information in <ulink
!       url="http://www.python.org/doc/FAQ.html#3.30">Python FAQ
!       3.30</ulink>.  On some operating systems you don't really have
!       to build a shared library, but then you will have to convince
!       the <productname>PostgreSQL</> build system of this.  Consult
!       the <filename>Makefile</filename> in the
        <filename>src/pl/plpython</filename> directory for details.
       </para>
      </listitem>
--- 193,203 ----
       </para>

       <para>
!       If you have problems, try running Python's configure using the
!       <literal>--enable-shared</> flag.  On some operating systems you
!       don't really have to build a shared library, but you will have
!       to convince the <productname>PostgreSQL</> build system of this.
!       Consult the <filename>Makefile</filename> in the
        <filename>src/pl/plpython</filename> directory for details.
       </para>
      </listitem>

Re: plperl doc update

From
Peter Eisentraut
Date:
Bruce Momjian wrote:
> I have applied the following doc update for plperl, now that perl has
> an --enable-shared configure option.

Maybe this should be rephrased to say that only newer versions (exactly
which?) have that option.


Re: plperl doc update

From
Tom Lane
Date:
Peter Eisentraut <peter_e@gmx.net> writes:
> Bruce Momjian wrote:
>> I have applied the following doc update for plperl, now that perl has
>> an --enable-shared configure option.

> Maybe this should be rephrased to say that only newer versions (exactly
> which?) have that option.

And why did the description say "plperl" when the patch changed
plpython?  Is the patch even correct?

            regards, tom lane

Re: plperl doc update

From
Bruce Momjian
Date:
Peter Eisentraut wrote:
> Bruce Momjian wrote:
> > I have applied the following doc update for plperl, now that perl has
> > an --enable-shared configure option.
>
> Maybe this should be rephrased to say that only newer versions (exactly
> which?) have that option.

I thought about that.  The docs were pointing to an FAQ number that
doesn't exit anymore, and there is text indicating sometimes the shared
compile isn't needed, so I didn't want to hard-code a version number in
case it wasn't significant aoyway.  And if I say newer, it will be
not-newer in a few years. :-)

I know Python 2.3 has the flag.  I think that is the first release that
has it, but I am not sure.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

Re: plperl doc update

From
Bruce Momjian
Date:
Tom Lane wrote:
> Peter Eisentraut <peter_e@gmx.net> writes:
> > Bruce Momjian wrote:
> >> I have applied the following doc update for plperl, now that perl has
> >> an --enable-shared configure option.
>
> > Maybe this should be rephrased to say that only newer versions (exactly
> > which?) have that option.
>
> And why did the description say "plperl" when the patch changed
> plpython?  Is the patch even correct?

Sorry, plpython was the patch, and the commit has the right text.  I am
typing via satelite modem, so my typing is strained.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

Re: plperl doc update

From
Peter Eisentraut
Date:
Bruce Momjian wrote:
> I thought about that.  The docs were pointing to an FAQ number that
> doesn't exit anymore, and there is text indicating sometimes the
> shared compile isn't needed, so I didn't want to hard-code a version
> number in case it wasn't significant aoyway.  And if I say newer, it
> will be not-newer in a few years. :-)

If you say "x or newer" then that will be true forever unless they take
it back out.  We should also try to figure out a way for people to find
out how their python was compiled rather than making them compile a new
one.

I would prefer to put more effort into giving people a procedure to
follow during PostgreSQL installation to verify the correct setup of
their system, rather than giving them a bunch of options to "try" when
they have unidentified "problems".


Re: plperl doc update

From
Bruce Momjian
Date:
Sure.  Anyone want to research this?

---------------------------------------------------------------------------

Peter Eisentraut wrote:
> Bruce Momjian wrote:
> > I thought about that.  The docs were pointing to an FAQ number that
> > doesn't exit anymore, and there is text indicating sometimes the
> > shared compile isn't needed, so I didn't want to hard-code a version
> > number in case it wasn't significant aoyway.  And if I say newer, it
> > will be not-newer in a few years. :-)
>
> If you say "x or newer" then that will be true forever unless they take
> it back out.  We should also try to figure out a way for people to find
> out how their python was compiled rather than making them compile a new
> one.
>
> I would prefer to put more effort into giving people a procedure to
> follow during PostgreSQL installation to verify the correct setup of
> their system, rather than giving them a bunch of options to "try" when
> they have unidentified "problems".
>
>
> ---------------------------(end of broadcast)---------------------------
> TIP 7: don't forget to increase your free space map settings
>

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

plpython doc update

From
Bruce Momjian
Date:
Peter Eisentraut wrote:
> Bruce Momjian wrote:
> > I thought about that.  The docs were pointing to an FAQ number that
> > doesn't exit anymore, and there is text indicating sometimes the
> > shared compile isn't needed, so I didn't want to hard-code a version
> > number in case it wasn't significant aoyway.  And if I say newer, it
> > will be not-newer in a few years. :-)
>
> If you say "x or newer" then that will be true forever unless they take
> it back out.  We should also try to figure out a way for people to find
> out how their python was compiled rather than making them compile a new
> one.
>
> I would prefer to put more effort into giving people a procedure to
> follow during PostgreSQL installation to verify the correct setup of
> their system, rather than giving them a bunch of options to "try" when
> they have unidentified "problems".

I can confirm it was added in 2.3:

    http://www.python.org/doc/current/whatsnew/node20.html

Docs updated:

      If you have problems, run Python 2.3 or later's configure using the
      <literal>--enable-shared</> flag.  On some operating systems you
      don't have to build a shared library, but you will have
      to convince the <productname>PostgreSQL</> build system of this.
      Consult the <filename>Makefile</filename> in the
      <filename>src/pl/plpython</filename> directory for details.


--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073