Thread: timestamp() functions still documented
The functions timestamp(date) and timestamp(date, time) are still
documented, but cannot be used because the parser interprets
timestamp(xx) as timestamp with precision.
So the documentation of those functions ought to be removed, because it
confuses users (the same applies to the documentation of 7.2.1):
Index: doc/src/sgml/func.sgml
===================================================================
RCS file: /projects/cvsroot/pgsql/doc/src/sgml/func.sgml,v
retrieving revision 1.96
diff -c -r1.96 func.sgml
*** doc/src/sgml/func.sgml 2002/04/26 01:24:08 1.96
--- doc/src/sgml/func.sgml 2002/05/03 08:40:01
***************
*** 2730,2750 ****
<entry><literal>Wed Feb 21 17:01:13.000126 2001 EST</literal></entry>
</row>
- <row>
- <entry><function>timestamp</function>(<type>date</type>)</entry>
- <entry><type>timestamp</type></entry>
- <entry><type>date</type> to <type>timestamp</type></entry>
- <entry><literal>timestamp(date '2000-12-25')</literal></entry>
- <entry><literal>2000-12-25 00:00:00</literal></entry>
- </row>
-
- <row>
- <entry><function>timestamp</function>(<type>date</type>,
<type>time</type>)</entry>
- <entry><type>timestamp</type></entry>
- <entry><type>date</type> and <type>time</type> to
<type>timestamp</type></entry>
- <entry><literal>timestamp(date '1998-02-24',time
'23:07')</literal></entry>
- <entry><literal>1998-02-24 23:07:00</literal></entry>
- </row>
</tbody>
</tgroup>
</table>
--- 2730,2735 ----
There are seven timestamp() functions in pg_proc and I don't think any
of them can be used; should they not be removed or renamed?
--
Oliver Elphick Oliver.Elphick@lfix.co.uk
Isle of Wight http://www.lfix.co.uk/oliver
GPG: 1024D/3E1D0C1C: CA12 09E0 E8D5 8870 5839 932A 614D 4C34 3E1D 0C1C
"Rejoice with them that do rejoice, and weep with them
that weep." Romans 12:15
Attachment
Oliver Elphick <olly@lfix.co.uk> writes:
> There are seven timestamp() functions in pg_proc and I don't think any
> of them can be used; should they not be removed or renamed?
Not unless you want to break the cast operations that use these
functions. OID 2025 isn't a cast and perhaps should be renamed,
but the rest are correct as-is.
I do agree that something needs to be done with the documentation...
regards, tom lane
...
> There are seven timestamp() functions in pg_proc and I don't think any
> of them can be used; should they not be removed or renamed?
They are used internally for type coersion. The problem is only at the
parser level, where SQL9x mandates a conflicting syntax.
- Thomas
Patch applied. --------------------------------------------------------------------------- Oliver Elphick wrote: -- Start of PGP signed section. > The functions timestamp(date) and timestamp(date, time) are still > documented, but cannot be used because the parser interprets > timestamp(xx) as timestamp with precision. > > So the documentation of those functions ought to be removed, because it > confuses users (the same applies to the documentation of 7.2.1): > > Index: doc/src/sgml/func.sgml > =================================================================== > RCS file: /projects/cvsroot/pgsql/doc/src/sgml/func.sgml,v > retrieving revision 1.96 > diff -c -r1.96 func.sgml > *** doc/src/sgml/func.sgml 2002/04/26 01:24:08 1.96 > --- doc/src/sgml/func.sgml 2002/05/03 08:40:01 > *************** > *** 2730,2750 **** > <entry><literal>Wed Feb 21 17:01:13.000126 2001 EST</literal></entry> > </row> > > - <row> > - <entry><function>timestamp</function>(<type>date</type>)</entry> > - <entry><type>timestamp</type></entry> > - <entry><type>date</type> to <type>timestamp</type></entry> > - <entry><literal>timestamp(date '2000-12-25')</literal></entry> > - <entry><literal>2000-12-25 00:00:00</literal></entry> > - </row> > - > - <row> > - <entry><function>timestamp</function>(<type>date</type>, > <type>time</type>)</entry> > - <entry><type>timestamp</type></entry> > - <entry><type>date</type> and <type>time</type> to > <type>timestamp</type></entry> > - <entry><literal>timestamp(date '1998-02-24',time > '23:07')</literal></entry> > - <entry><literal>1998-02-24 23:07:00</literal></entry> > - </row> > </tbody> > </tgroup> > </table> > --- 2730,2735 ---- > > > There are seven timestamp() functions in pg_proc and I don't think any > of them can be used; should they not be removed or renamed? > > -- > Oliver Elphick Oliver.Elphick@lfix.co.uk > Isle of Wight http://www.lfix.co.uk/oliver > GPG: 1024D/3E1D0C1C: CA12 09E0 E8D5 8870 5839 932A 614D 4C34 3E1D 0C1C > > "Rejoice with them that do rejoice, and weep with them > that weep." Romans 12:15 -- End of PGP section. -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 853-3000 + If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania 19026