Thread: pgsql: Fix parallel-safety markings for contrib/dblink.

pgsql: Fix parallel-safety markings for contrib/dblink.

From
Tom Lane
Date:
Fix parallel-safety markings for contrib/dblink.

As shown by buildfarm reports, dblink_build_sql_insert and
dblink_build_sql_update are *not* parallel safe, because they
may attempt to access temporary tables of the local session.

Although dblink_build_sql_delete doesn't actually touch the
contents of the referenced table, it seems consistent and prudent
to mark it PARALLEL RESTRICTED too.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/7e81a18d49f2ffc3397bde2660b255b56d8a6d77

Modified Files
--------------
contrib/dblink/dblink--1.1--1.2.sql | 6 +++---
contrib/dblink/dblink--1.2.sql      | 6 +++---
2 files changed, 6 insertions(+), 6 deletions(-)


Re: pgsql: Fix parallel-safety markings for contrib/dblink.

From
Robert Haas
Date:
On Fri, Jun 17, 2016 at 11:08 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Fix parallel-safety markings for contrib/dblink.
>
> As shown by buildfarm reports, dblink_build_sql_insert and
> dblink_build_sql_update are *not* parallel safe, because they
> may attempt to access temporary tables of the local session.
>
> Although dblink_build_sql_delete doesn't actually touch the
> contents of the referenced table, it seems consistent and prudent
> to mark it PARALLEL RESTRICTED too.

Ugh, thanks.  I thought that's how they WERE marked, but evidently my
eyes were crossing by this point.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company