Thread: pgsql: Remove redundant CREATEUSER/NOCREATEUSER options in CREATE ROLE

pgsql: Remove redundant CREATEUSER/NOCREATEUSER options in CREATE ROLE

From
Tom Lane
Date:
Remove redundant CREATEUSER/NOCREATEUSER options in CREATE ROLE et al.

Once upon a time we did not have a separate CREATEROLE privilege, and
CREATEUSER effectively meant SUPERUSER.  When we invented CREATEROLE
(in 8.1) we also added SUPERUSER so as to have a less confusing keyword
for this role property.  However, we left CREATEUSER in place as a
deprecated synonym for SUPERUSER, because of backwards-compatibility
concerns.  It's still there and is still confusing people, as for example
in bug #13694 from Justin Catterson.  9.6 will be ten years or so later,
which surely ought to be long enough to end the deprecation and just
remove these old keywords.  Hence, do so.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/d371bebd3d16949171282c8252dfd6f82d2e7378

Modified Files
--------------
doc/src/sgml/ref/alter_role.sgml                     |    3 ---
doc/src/sgml/ref/alter_user.sgml                     |    1 -
doc/src/sgml/ref/create_group.sgml                   |    1 -
doc/src/sgml/ref/create_role.sgml                    |   14 --------------
doc/src/sgml/ref/create_user.sgml                    |    1 -
src/backend/parser/gram.y                            |   10 ----------
src/backend/utils/mb/conversion_procs/regress_prolog |    2 +-
src/bin/psql/tab-complete.c                          |   16 ++++++++--------
src/test/regress/expected/conversion.out             |    2 +-
src/test/regress/sql/conversion.sql                  |    2 +-
10 files changed, 11 insertions(+), 41 deletions(-)