Thread: pgsql: Fix broken multibyte regression tests.
Fix broken multibyte regression tests. commit 9043Fe390f4f0b4586cfe59cbd22314b9c3e2957 broke multibyte regression tests because the commit removes the warning message when temporary hash indexes is created, which has been added by commit 07af523870bcfe930134054febd3a6a114942e5b. Back patched to 9.5 stable tree. Branch ------ master Details ------- http://git.postgresql.org/pg/commitdiff/efc1610b64b04e7cf08cc1d6c608ede8b7d5ff07 Modified Files -------------- src/test/mb/expected/big5.out | 1 - src/test/mb/expected/euc_jp.out | 1 - src/test/mb/expected/euc_kr.out | 1 - src/test/mb/expected/euc_tw.out | 1 - src/test/mb/expected/gb18030.out | 1 - src/test/mb/expected/mule_internal.out | 2 -- src/test/mb/expected/sjis.out | 1 - src/test/mb/expected/utf8.out | 1 - 8 files changed, 9 deletions(-)
On Sat, Aug 8, 2015 at 10:09 PM, Tatsuo Ishii <ishii@postgresql.org> wrote: > Fix broken multibyte regression tests. > > commit 9043Fe390f4f0b4586cfe59cbd22314b9c3e2957 broke multibyte That commit ID isn't valid; should be 9043ef390f4f0b4586cfe59cbd22314b9c3e2957 - looks like ef got turned into fe. Sorry about the oversight. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
> On Sat, Aug 8, 2015 at 10:09 PM, Tatsuo Ishii <ishii@postgresql.org> wrote: >> Fix broken multibyte regression tests. >> >> commit 9043Fe390f4f0b4586cfe59cbd22314b9c3e2957 broke multibyte > > That commit ID isn't valid; should be > 9043ef390f4f0b4586cfe59cbd22314b9c3e2957 - looks like ef got turned > into fe. Sorry for it. I seemd to touch wrong emacs keys. > Sorry about the oversight. No problem. The test is not in the regular regression suits, and it is hard to find a brokenness. Best regards, -- Tatsuo Ishii SRA OSS, Inc. Japan English: http://www.sraoss.co.jp/index_en.php Japanese:http://www.sraoss.co.jp
Tatsuo Ishii <ishii@postgresql.org> writes:
> Fix broken multibyte regression tests.
> commit 9043Fe390f4f0b4586cfe59cbd22314b9c3e2957 broke multibyte
> regression tests because the commit removes the warning message when
> temporary hash indexes is created, which has been added by commit
> 07af523870bcfe930134054febd3a6a114942e5b.
> Back patched to 9.5 stable tree.
AFAICT this patch was incorrect and should be reverted, because the
src/test/mb tests all fail for me, in both HEAD and 9.5, as a consequence
of getting hash-index WARNINGs that are not in the expected-files. The
commit you mention (which is 9043ef390f4f0b4586cfe59cbd22314b9c3e2957 not
what's cited in this commit message) disabled the WARNING for temporary
and unlogged hash indexes, but the indexes created by the test scripts
are neither.
Please recheck it.
regards, tom lane