Thread: pgsql: Restore use of zlib default compression in pg_dump directory mod

Restore use of zlib default compression in pg_dump directory mode.

This was broken by commit 0e7e355f27302b62af3e1add93853ccd45678443 and
friends, which ignored the fact that gzopen() will treat "-1" in the
mode argument as an invalid character, which it ignores, and a flag for
compression level 1. Now, when this value is encountered no compression
level flag is passed  to gzopen, leaving it to use the zlib default.

Also, enforce the documented allowed range for pg_dump's -Z option,
namely 0 .. 9, and remove some consequently dead code from
pg_backup_tar.c.

Problem reported by Marc Mamin.

Backpatch to 9.1, like the patch that introduced the bug.

Branch
------
REL9_1_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/af225551ef8435eb911e0b063358c42fcdecb853

Modified Files
--------------
src/bin/pg_dump/compress_io.c   |   18 ++++++++++++++----
src/bin/pg_dump/pg_backup_tar.c |    7 -------
src/bin/pg_dump/pg_dump.c       |    5 +++++
3 files changed, 19 insertions(+), 11 deletions(-)

Andrew Dunstan <andrew@dunslane.net> writes:
> Restore use of zlib default compression in pg_dump directory mode.

Buildfarm's not too happy with the 9.1 version of this.

            regards, tom lane

On 07/25/2015 05:57 PM, Tom Lane wrote:
> Andrew Dunstan <andrew@dunslane.net> writes:
>> Restore use of zlib default compression in pg_dump directory mode.
> Buildfarm's not too happy with the 9.1 version of this.
>
>

Oops. Will fix.

cheers

andrew