Thread: pgsql: Fix some problems with patch to fsync the data directory.
Fix some problems with patch to fsync the data directory. pg_win32_is_junction() was a typo for pgwin32_is_junction(). open() was used not only in a two-argument form, which breaks on Windows, but also where BasicOpenFile() should have been used. Per reports from Andrew Dunstan and David Rowley. Branch ------ REL9_0_STABLE Details ------- http://git.postgresql.org/pg/commitdiff/262fbcb9dd4a357a8b8147b6ac217b41e905be3a Modified Files -------------- src/backend/storage/file/fd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Robert Haas <rhaas@postgresql.org> writes:
> Fix some problems with patch to fsync the data directory.
Buildfarm is still not happy with the 9.0 branch:
"c:\prog\bf\root\REL9_0_STABLE\pgsql.build\pgsql.sln" (default target) (1) ->
(postgres target) ->
fd.obj : error LNK2019: unresolved external symbol _readlink referenced in function _walkdir
fd.obj : error LNK2019: unresolved external symbol _pgwin32_is_junction referenced in function _walkdir
.\Release\postgres\postgres.exe : fatal error LNK1120: 2 unresolved externals
Looks like some more back-porting is needed.
regards, tom lane
On Tue, May 5, 2015 at 12:52 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote: > Robert Haas <rhaas@postgresql.org> writes: >> Fix some problems with patch to fsync the data directory. > > Buildfarm is still not happy with the 9.0 branch: > > "c:\prog\bf\root\REL9_0_STABLE\pgsql.build\pgsql.sln" (default target) (1) -> > (postgres target) -> > fd.obj : error LNK2019: unresolved external symbol _readlink referenced in function _walkdir > fd.obj : error LNK2019: unresolved external symbol _pgwin32_is_junction referenced in function _walkdir > .\Release\postgres\postgres.exe : fatal error LNK1120: 2 unresolved externals Whee! OK, let me look at what may be required there. Or, heh heh, Abhijit could jump here any time, since it's his patch...! -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company