Thread: pgsql: Oops, I fumbled the backpatch of pg_upgrade changes.
Oops, I fumbled the backpatch of pg_upgrade changes. Somehow I got 9.2 and 9.4 correct, but fumbled 9.3. Branch ------ REL9_3_STABLE Details ------- http://git.postgresql.org/pg/commitdiff/9945f4e0f546f2e53b430fba32831ae6c73abb78 Modified Files -------------- contrib/pg_upgrade/check.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-)
On 10/25/14 2:00 PM, Heikki Linnakangas wrote: > Oops, I fumbled the backpatch of pg_upgrade changes. > > Somehow I got 9.2 and 9.4 correct, but fumbled 9.3. This is still producing a compiler warning: check.c:471:2: error: implicit declaration of function 'pg_valid_server_encoding' [-Werror=implicit-function-declaration]
On Sat, Nov 1, 2014 at 10:22 PM, Peter Eisentraut <peter_e@gmx.net> wrote:
check.c is missing an inclusion of mb/pg_wchar.h on 9.3 only.On 10/25/14 2:00 PM, Heikki Linnakangas wrote:
> Oops, I fumbled the backpatch of pg_upgrade changes.
>
> Somehow I got 9.2 and 9.4 correct, but fumbled 9.3.
This is still producing a compiler warning:
check.c:471:2: error: implicit declaration of function
'pg_valid_server_encoding' [-Werror=implicit-function-declaration]
--
Michael
Attachment
On 11/01/2014 03:36 PM, Michael Paquier wrote: > On Sat, Nov 1, 2014 at 10:22 PM, Peter Eisentraut <peter_e@gmx.net> wrote: > >> On 10/25/14 2:00 PM, Heikki Linnakangas wrote: >>> Oops, I fumbled the backpatch of pg_upgrade changes. >>> >>> Somehow I got 9.2 and 9.4 correct, but fumbled 9.3. >> >> This is still producing a compiler warning: >> >> check.c:471:2: error: implicit declaration of function >> 'pg_valid_server_encoding' [-Werror=implicit-function-declaration] >> > check.c is missing an inclusion of mb/pg_wchar.h on 9.3 only. Thanks, fixed. - Heikki