Thread: pgsql: pg_upgrade: prevent automatic oid assignment

pgsql: pg_upgrade: prevent automatic oid assignment

From
Bruce Momjian
Date:
pg_upgrade:  prevent automatic oid assignment

Prevent automatic oid assignment when in binary upgrade mode.  Also
throw an error when contrib/pg_upgrade_support functions are called when
not in binary upgrade mode.

This prevent automatically-assigned oids from conflicting with later
pre-assigned oids coming from the old cluster.  It also makes sure oids
are preserved in call important cases.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/a7ae1dcf4939cf643c5abe8dd673e4b87a6efd42

Modified Files
--------------
contrib/pg_upgrade_support/pg_upgrade_support.c |   17 +++++++++++++++++
src/backend/catalog/heap.c                      |   12 +++++++-----
src/backend/catalog/index.c                     |   13 +++++++------
src/backend/catalog/pg_enum.c                   |    7 ++++++-
src/backend/catalog/pg_type.c                   |   16 +++++++++++++---
src/backend/catalog/toasting.c                  |    6 +++++-
src/backend/commands/typecmds.c                 |    9 +++++++--
src/backend/commands/user.c                     |    9 +++++++--
8 files changed, 69 insertions(+), 20 deletions(-)


Re: pgsql: pg_upgrade: prevent automatic oid assignment

From
Tom Lane
Date:
Bruce Momjian <bruce@momjian.us> writes:
> pg_upgrade:  prevent automatic oid assignment

One or another of these pg_upgrade changes broke the Windows build.

            regards, tom lane


Re: pgsql: pg_upgrade: prevent automatic oid assignment

From
Bruce Momjian
Date:
On Tue, Aug 26, 2014 at 01:25:45AM -0400, Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > pg_upgrade:  prevent automatic oid assignment
>
> One or another of these pg_upgrade changes broke the Windows build.

Yeah, it was a PGDLLIMPORT, already fixed.

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + Everyone has their own god. +