Thread: pgsql: Silence a couple of spurious valgrind warnings in inval.c.

pgsql: Silence a couple of spurious valgrind warnings in inval.c.

From
Andres Freund
Date:
Silence a couple of spurious valgrind warnings in inval.c.

Define padding bytes in SharedInvalidationMessage structs to be
defined. Otherwise the sinvaladt.c ringbuffer, which is accessed by
multiple processes, will cause spurious valgrind warnings about
undefined memory being used. That's because valgrind remembers the
undefined bytes from the last local process's store, not realizing
that another process has written since, filling the previously
uninitialized bytes.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/0564bbe7a1690f025f4424d5a12cb6af9d428c48

Modified Files
--------------
src/backend/utils/cache/inval.c |   27 +++++++++++++++++++++++++++
1 file changed, 27 insertions(+)


Re: pgsql: Silence a couple of spurious valgrind warnings in inval.c.

From
Robert Haas
Date:
On Sat, May 24, 2014 at 1:11 PM, Andres Freund <andres@anarazel.de> wrote:
> Silence a couple of spurious valgrind warnings in inval.c.

Congratulations on your first commit!

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company