Thread: pgsql: During index build, check and elog (not just Assert) for broken

pgsql: During index build, check and elog (not just Assert) for broken

From
Tom Lane
Date:
During index build, check and elog (not just Assert) for broken HOT chain.

The recently-fixed bug in WAL replay could result in not finding a parent
tuple for a heap-only tuple.  The existing code would either Assert or
generate an invalid index entry, neither of which is desirable.  Throw a
regular error instead.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/d70cf811f7dd26c07dbb78df4a51b667e7a3489b

Modified Files
--------------
src/backend/catalog/index.c |   11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)


Re: pgsql: During index build, check and elog (not just Assert) for broken

From
Alvaro Herrera
Date:
Tom Lane wrote:
> During index build, check and elog (not just Assert) for broken HOT chain.
>
> The recently-fixed bug in WAL replay could result in not finding a parent
> tuple for a heap-only tuple.  The existing code would either Assert or
> generate an invalid index entry, neither of which is desirable.  Throw a
> regular error instead.

Thanks.

--
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services