Thread: pgsql: Fix typos in comments.
Fix typos in comments. Thom Brown Branch ------ master Details ------- http://git.postgresql.org/pg/commitdiff/2bccced110025f48bf426a8a9d7f627ef3663fcd Modified Files -------------- contrib/pgcrypto/openssl.c | 2 +- doc/src/sgml/gin.sgml | 2 +- src/backend/access/gin/ginget.c | 2 +- src/backend/access/gin/ginlogic.c | 2 +- src/backend/access/heap/rewriteheap.c | 6 +++--- src/backend/lib/ilist.c | 2 +- src/backend/replication/logical/logical.c | 2 +- src/backend/replication/logical/snapbuild.c | 4 ++-- src/backend/rewrite/rewriteHandler.c | 2 +- src/backend/utils/adt/json.c | 4 ++-- src/backend/utils/time/tqual.c | 8 ++++---- 11 files changed, 18 insertions(+), 18 deletions(-)
Fujii Masao wrote: > src/backend/access/heap/rewriteheap.c | 6 +++--- This one wasn't strictly a typo: @@ -1046,7 +1046,7 @@ logical_rewrite_log_mapping(RewriteState state, TransactionId xid, /* * Perform logical remapping for a tuple that's mapped from old_tid to - * new_tuple->t_self by rewrite_heap_tuple() iff necessary for the tuple. + * new_tuple->t_self by rewrite_heap_tuple() if necessary for the tuple. */ "iff" was discussed in pg-hackers a fortnight ago or so. In this particular case I don't think "iff" rather than "if" added too much to the sentence, though, so I think it's fine as it is. -- Álvaro Herrera http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services
On 17 March 2014 12:44, Alvaro Herrera <alvherre@2ndquadrant.com> wrote: > Fujii Masao wrote: > >> src/backend/access/heap/rewriteheap.c | 6 +++--- > > This one wasn't strictly a typo: > > @@ -1046,7 +1046,7 @@ logical_rewrite_log_mapping(RewriteState state, TransactionId xid, > > /* > * Perform logical remapping for a tuple that's mapped from old_tid to > - * new_tuple->t_self by rewrite_heap_tuple() iff necessary for the tuple. > + * new_tuple->t_self by rewrite_heap_tuple() if necessary for the tuple. > */ > > > "iff" was discussed in pg-hackers a fortnight ago or so. In this > particular case I don't think "iff" rather than "if" added too much to > the sentence, though, so I think it's fine as it is. Could you elaborate, for my sake? -- Thom
Thom Brown <thom@linux.com> writes:
> On 17 March 2014 12:44, Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
>> "iff" was discussed in pg-hackers a fortnight ago or so. In this
>> particular case I don't think "iff" rather than "if" added too much to
>> the sentence, though, so I think it's fine as it is.
> Could you elaborate, for my sake?
"iff" is a standard abbreviation for "if and only if".
regards, tom lane
On 17 March 2014 17:00, Tom Lane <tgl@sss.pgh.pa.us> wrote: > Thom Brown <thom@linux.com> writes: >> On 17 March 2014 12:44, Alvaro Herrera <alvherre@2ndquadrant.com> wrote: >>> "iff" was discussed in pg-hackers a fortnight ago or so. In this >>> particular case I don't think "iff" rather than "if" added too much to >>> the sentence, though, so I think it's fine as it is. > >> Could you elaborate, for my sake? > > "iff" is a standard abbreviation for "if and only if". Oh I see, like <-> or ||| (if you tilt your head sideways). Okay, my bad. Thanks for the explanation. -- Thom