Thread: pgsql: Fix booltestsel() for case where we have NULL stats but not MCV

Fix booltestsel() for case where we have NULL stats but not MCV stats.

In a boolean column that contains mostly nulls, ANALYZE might not find
enough non-null values to populate the most-common-values stats,
but it would still create a pg_statistic entry with stanullfrac set.
The logic in booltestsel() for this situation did the wrong thing for
"col IS NOT TRUE" and "col IS NOT FALSE" tests, forgetting that null
values would satisfy these tests (so that the true selectivity would
be close to one, not close to zero).  Per bug #8274.

Fix by Andrew Gierth, some comment-smithing by me.

Branch
------
REL9_0_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/8e992b01864198af954111ffee9b05635c0ae4c0

Modified Files
--------------
src/backend/utils/adt/selfuncs.c |   22 ++++++++++------------
1 file changed, 10 insertions(+), 12 deletions(-)