Thread: pgsql: Prevent failure when RowExpr or XmlExpr is parse-analyzed twice.

pgsql: Prevent failure when RowExpr or XmlExpr is parse-analyzed twice.

From
Tom Lane
Date:
Prevent failure when RowExpr or XmlExpr is parse-analyzed twice.

transformExpr() is required to cope with already-transformed expression
trees, for various ugly-but-not-quite-worth-cleaning-up reasons.  However,
some of its newer subroutines hadn't gotten the memo.  This accounts for
bug #7763 from Norbert Buchmuller: transformRowExpr() was overwriting the
previously determined type of a RowExpr during CREATE TABLE LIKE INCLUDING
INDEXES.  Additional investigation showed that transformXmlExpr had the
same kind of problem, but all the other cases seem to be safe.

Andres Freund and Tom Lane

Branch
------
REL9_0_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/a91c411772fdc9708c535e78d6fec26eacd45b24

Modified Files
--------------
src/backend/parser/gram.y       |    1 +
src/backend/parser/parse_expr.c |   19 +++++++++++++++++--
2 files changed, 18 insertions(+), 2 deletions(-)