Thread: pgsql: Add alter_generic regression test

pgsql: Add alter_generic regression test

From
Alvaro Herrera
Date:
Add alter_generic regression test

This makes refactoring of parts of the ALTER command safe(r) because we
ensure no change in functionality.

Author: KaiGai Kohei

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/ff7e5b4841eeedfb9cefec6226f4dca5b8840276

Modified Files
--------------
src/test/regress/expected/alter_generic.out |  545 +++++++++++++++++++++++++++
src/test/regress/parallel_schedule          |    2 +-
src/test/regress/serial_schedule            |    1 +
src/test/regress/sql/alter_generic.sql      |  417 ++++++++++++++++++++
4 files changed, 964 insertions(+), 1 deletions(-)


Re: pgsql: Add alter_generic regression test

From
Tom Lane
Date:
Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> Add alter_generic regression test
> This makes refactoring of parts of the ALTER command safe(r) because we
> ensure no change in functionality.

The buildfarm doesn't like this patch at all, because it fails to cover
machines without collation support.  I also note that you ignored this
comment in parallel_schedule:

# NB: temp.sql does a reconnect which transiently uses 2 connections,
# so keep this parallel group to at most 19 tests

            regards, tom lane