Thread: pgsql: Back-patch recent fixes for gistchoose and gistRelocateBuildBuff

pgsql: Back-patch recent fixes for gistchoose and gistRelocateBuildBuff

From
Tom Lane
Date:
Back-patch recent fixes for gistchoose and gistRelocateBuildBuffersOnSplit.

This back-ports commits c8ba697a4bdb934f0c51424c654e8db6133ea255 and
e5db11c5582b469c04a11f217a0f32c827da5dd7, which fix one definite and one
speculative bug in gistchoose, and make the code a lot more intelligible as
well.  In 9.2 only, this also affects the largely-copied-and-pasted logic
in gistRelocateBuildBuffersOnSplit.

The impact of the bugs was that the functions might make poor decisions
as to which index tree branch to push a new entry down into, resulting in
GiST index bloat and poor performance.  The fixes rectify these decisions
for future insertions, but a REINDEX would be needed to clean up any
existing index bloat.

Alexander Korotkov, Robert Haas, Tom Lane

Branch
------
REL9_2_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/d2528e5dbf1ad6e391f40712a27d4d199b43100d

Modified Files
--------------
src/backend/access/gist/gistbuildbuffers.c |   89 +++++++++++++++++++------
src/backend/access/gist/gistutil.c         |   98 +++++++++++++++++++++-------
2 files changed, 141 insertions(+), 46 deletions(-)