Thread: pgsql: Add missing period to detail message.

pgsql: Add missing period to detail message.

From
Robert Haas
Date:
Add missing period to detail message.

Per note from Peter Eisentraut.

Branch
------
REL8_3_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/588fb3f01f7159990a9bfabb578615c3c32ffc6e

Modified Files
--------------
src/backend/storage/lmgr/proc.c |    2 +-
1 files changed, 1 insertions(+), 1 deletions(-)


Re: pgsql: Add missing period to detail message.

From
Bruce Momjian
Date:
On Thu, Aug 30, 2012 at 05:28:17PM +0000, Robert Haas wrote:
> Add missing period to detail message.
>
> Per note from Peter Eisentraut.
>
> Branch
> ------
> REL8_3_STABLE
>
> Details
> -------
> http://git.postgresql.org/pg/commitdiff/588fb3f01f7159990a9bfabb578615c3c32ffc6e
>
> Modified Files
> --------------
> src/backend/storage/lmgr/proc.c |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)

I didn't think we backpatched error string changes because of
translation churn.

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + It's impossible for everything to be true. +


Re: pgsql: Add missing period to detail message.

From
Robert Haas
Date:
On Thu, Aug 30, 2012 at 2:08 PM, Bruce Momjian <bruce@momjian.us> wrote:
> On Thu, Aug 30, 2012 at 05:28:17PM +0000, Robert Haas wrote:
>> Add missing period to detail message.
>>
>> Per note from Peter Eisentraut.
>>
>> Branch
>> ------
>> REL8_3_STABLE
>>
>> Details
>> -------
>> http://git.postgresql.org/pg/commitdiff/588fb3f01f7159990a9bfabb578615c3c32ffc6e
>>
>> Modified Files
>> --------------
>> src/backend/storage/lmgr/proc.c |    2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> I didn't think we backpatched error string changes because of
> translation churn.

Well, the patch that this was related to was back-patched, so I
figured this should be, too.  That concern did cross my mind, though.
I can revert in the back branches if the translations team prefers.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


Re: pgsql: Add missing period to detail message.

From
Bruce Momjian
Date:
On Thu, Aug 30, 2012 at 03:02:28PM -0400, Robert Haas wrote:
> On Thu, Aug 30, 2012 at 2:08 PM, Bruce Momjian <bruce@momjian.us> wrote:
> > On Thu, Aug 30, 2012 at 05:28:17PM +0000, Robert Haas wrote:
> >> Add missing period to detail message.
> >>
> >> Per note from Peter Eisentraut.
> >>
> >> Branch
> >> ------
> >> REL8_3_STABLE
> >>
> >> Details
> >> -------
> >> http://git.postgresql.org/pg/commitdiff/588fb3f01f7159990a9bfabb578615c3c32ffc6e
> >>
> >> Modified Files
> >> --------------
> >> src/backend/storage/lmgr/proc.c |    2 +-
> >> 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > I didn't think we backpatched error string changes because of
> > translation churn.
>
> Well, the patch that this was related to was back-patched, so I
> figured this should be, too.  That concern did cross my mind, though.
> I can revert in the back branches if the translations team prefers.

Oh, if the patch was backpatched, the error message churn probably isn't
a problem then.

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + It's impossible for everything to be true. +


Re: pgsql: Add missing period to detail message.

From
Tom Lane
Date:
Bruce Momjian <bruce@momjian.us> writes:
> On Thu, Aug 30, 2012 at 03:02:28PM -0400, Robert Haas wrote:
>> On Thu, Aug 30, 2012 at 2:08 PM, Bruce Momjian <bruce@momjian.us> wrote:
>>> I didn't think we backpatched error string changes because of
>>> translation churn.

>> Well, the patch that this was related to was back-patched, so I
>> figured this should be, too.  That concern did cross my mind, though.
>> I can revert in the back branches if the translations team prefers.

> Oh, if the patch was backpatched, the error message churn probably isn't
> a problem then.

The message itself is new as of earlier this month, no?  So likely
nobody has translated it yet anyway.  Probably better to get it right
now.

            regards, tom lane